[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/8] qapi: Formalize qcow2 encryption probing
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/8] qapi: Formalize qcow2 encryption probing |
Date: |
Wed, 6 Feb 2019 14:23:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/6/19 1:55 PM, Max Reitz wrote:
> Currently, you can give no encryption format for a qcow2 file while
> still passing a key-secret. That does not conform to the schema, so
> this patch changes the schema to allow it.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qapi/block-core.json | 31 ++++++++++++++++++++++++++++---
> block/qcow2.c | 3 +++
> 2 files changed, 31 insertions(+), 3 deletions(-)
>
> @@ -2961,10 +2964,30 @@
> # @BlockdevQcow2EncryptionFormat:
> # @aes: AES-CBC with plain64 initialization venctors
We should fix that typo.
> #
> +# @auto: Determine the encryption format from the image
> +# header. This only allows the use of the
> +# key-secret option. (Since: 4.0)
> +#
> # Since: 2.10
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/8] block: Try to create well-typed json:{} filenames, Max Reitz, 2019/02/06
- [Qemu-devel] [PATCH v3 4/8] qapi: Formalize qcow2 encryption probing, Max Reitz, 2019/02/06
- Re: [Qemu-devel] [PATCH v3 4/8] qapi: Formalize qcow2 encryption probing,
Eric Blake <=
- [Qemu-devel] [PATCH v3 3/8] tests: Add QAPI optional discriminator tests, Max Reitz, 2019/02/06
- [Qemu-devel] [PATCH v3 5/8] qapi: Formalize qcow encryption probing, Max Reitz, 2019/02/06
- [Qemu-devel] [PATCH v3 6/8] block: Try to create well typed json:{} filenames, Max Reitz, 2019/02/06
- [Qemu-devel] [PATCH v3 7/8] iotests: Test internal option typing, Max Reitz, 2019/02/06
- [Qemu-devel] [PATCH v3 8/8] iotests: qcow2's encrypt.format is now optional, Max Reitz, 2019/02/06