[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] main-loop: Don't leak GSources attached to
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] main-loop: Don't leak GSources attached to a GMainContext |
Date: |
Thu, 7 Feb 2019 14:21:06 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Feb 07, 2019 at 03:23:21PM +0200, Alberto Garcia wrote:
> After g_source_attach() the GMainContext holds a reference to the
> GSource, so the caller does not need to keep it.
>
> pty_chr_state() and qio_task_thread_worker() are not doing this, so
> the GSource is being leaked in both cases (pty_chr_open_src_cancel()
> is the exception here because it does remove the extra reference
> correctly).
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> chardev/char-pty.c | 2 +-
> io/task.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[Qemu-devel] [PATCH 3/3] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout(), Alberto Garcia, 2019/02/07