Re: [Qemu-devel] [PATCH 05/51] kconfig: introduce kconfig files

[Thomas Huth]

On 2019-02-07 18:56, Paolo Bonzini wrote:
> The Kconfig files were generated mostly with this script:
> 
>   for i in `grep -ho CONFIG_[A-Z0-9_]* default-configs/* | sort -u`; do
>     set fnord `git grep -lw $i -- 'hw/*/Makefile.objs' `
>     shift
>     if test $# = 1; then
>       cat >> $(dirname $1)/Kconfig << EOF
> config ${i#CONFIG_}
>     bool
> 
> EOF
>       git add $(dirname $1)/Kconfig
>     else
>       echo $i $*
>     fi
>   done
>   sed -i '$d' hw/*/Kconfig
>   for i in hw/*; do
>     if test -d $i && ! test -f $i/Kconfig; then
>       touch $i/Kconfig
>       git add $i/Kconfig
>     fi
>   done
> 
> Whenever a symbol is referenced from multiple subdirectories, the
> script prints the list of directories that reference the symbol.
> These symbols have to be added manually to the Kconfig files.
> 
> Kconfig.host and hw/Kconfig were created manually.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Yang Zhong <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Duplicated S-o-b ... doesn't hurt, but looks a little bit weird...

[...]
> diff --git a/hw/m68k/Kconfig b/hw/m68k/Kconfig
> new file mode 100644
> index 0000000..cd66ada
> --- /dev/null
> +++ b/hw/m68k/Kconfig
> @@ -0,0 +1,8 @@
> +config AN5206
> +    bool
> +
> +config MCF5206
> +    bool

As far as I can see, the MCF5206 switch is not necessary?

> +config MCF5208
> +    bool
[...]
> diff --git a/hw/net/Kconfig b/hw/net/Kconfig
> new file mode 100644
> index 0000000..d358b2c
> --- /dev/null
> +++ b/hw/net/Kconfig
> @@ -0,0 +1,92 @@
> +config DP8393X
> +    bool
> +
> +config NE2000_PCI
> +    bool
> +
> +config EEPRO100_PCI
> +    bool
> +
> +config PCNET_PCI
> +    bool
> +
> +config PCNET_COMMON
> +    bool
> +
> +config E1000_PCI
> +    bool
> +
> +config E1000E_PCI_EXPRESS
> +    bool
> +
> +config RTL8139_PCI
> +    bool
> +
> +config VMXNET3_PCI
> +    bool
> +
> +config SMC91C111
> +    bool
> +
> +config LAN9118
> +    bool
> +
> +config NE2000_ISA
> +    bool
> +
> +config OPENCORES_ETH
> +    bool
> +
> +config XGMAC
> +    bool
> +
> +config MIPSNET
> +    bool
> +
> +config ALLWINNER_EMAC
> +    bool
> +
> +config IMX_FEC
> +    bool
> +
> +config CADENCE
> +    bool
> +
> +config STELLARIS_ENET
> +    bool
> +
> +config LANCE
> +    bool
> +
> +config SUNHME
> +    bool
> +
> +config FTGMAC100
> +    bool
> +
> +config SUNGEM
> +    bool
> +
> +config COLDFIRE
> +    bool

Could you please move COLDFIRE to hw/m68k/Kconfig ? The switch is also
used for other Coldfire-related files that do not reside in hw/net/ .

 Thanks,
  Thomas