[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULLv4 27/32] slirp: improve send_packet() callback
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PULLv4 27/32] slirp: improve send_packet() callback |
Date: |
Thu, 7 Feb 2019 21:04:58 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
Philippe Mathieu-Daudé, le jeu. 07 févr. 2019 19:31:49 +0100, a ecrit:
> > + if (ret < 0) {
> > + g_critical("Failed to send packet, ret: %ld", (long) ret);
>
> From the v3 discussion [*] I thought send_packet() would return a
> gssize, then we'd use G_GSSIZE_FORMAT here (and similarly use gssize
> instead ssize_t in this series).
> Anyway your fix is simpler.
That was the idea of my fix, yes :)
Samuel
- [Qemu-devel] [PULLv4 18/32] slirp: add slirp own version of pstrcpy, (continued)
- [Qemu-devel] [PULLv4 18/32] slirp: add slirp own version of pstrcpy, Samuel Thibault, 2019/02/07
- [Qemu-devel] [PULLv4 25/32] slirp: replace remaining qemu headers dependency, Samuel Thibault, 2019/02/07
- [Qemu-devel] [PULLv4 30/32] slirp: use polling callbacks, drop glib requirement, Samuel Thibault, 2019/02/07
- [Qemu-devel] [PULLv4 22/32] slirp: replace qemu qtailq with slirp own copy, Samuel Thibault, 2019/02/07
- [Qemu-devel] [PULLv4 26/32] slirp: prefer c99 types over BSD kind, Samuel Thibault, 2019/02/07
- [Qemu-devel] [PULLv4 32/32] slirp: API is extern C, Samuel Thibault, 2019/02/07
- [Qemu-devel] [PULLv4 28/32] slirp: replace global polling with per-instance & notifier, Samuel Thibault, 2019/02/07
- [Qemu-devel] [PULLv4 12/32] slirp: replace qemu_set_nonblock(), Samuel Thibault, 2019/02/07
- [Qemu-devel] [PULLv4 27/32] slirp: improve send_packet() callback, Samuel Thibault, 2019/02/07
- [Qemu-devel] [PULLv4 17/32] slirp: improve windows headers inclusion, Samuel Thibault, 2019/02/07
- [Qemu-devel] [PULLv4 29/32] slirp: remove slirp_instances list, Samuel Thibault, 2019/02/07
- Re: [Qemu-devel] [PULLv4 00/32] More work towards libslirp, no-reply, 2019/02/07
- Re: [Qemu-devel] [PULLv4 00/32] More work towards libslirp, Peter Maydell, 2019/02/08