Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for 
path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) 
registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 
'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 
'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered 
for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) 
registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) 
registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for 
path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) 
registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for 
path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for 
path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for 
path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) 
registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' 
(https://github.com/cota/berkeley-softfloat-3) registered for path 
'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' 
(https://github.com/cota/berkeley-testfloat-3) registered for path 
'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) 
registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out 
'22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out 
'90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 
'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 
'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 
'441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 
'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 
'51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 
'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out 
'1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 
'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 
'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 
'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out 
'60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 
'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out 
'5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out 
'6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
93b682d FIXME vhost: add more stubs
a680cbc .travis.yml: test that no-default-device builds do not regress
cc20b7d xtensa-softmmu.mak: express dependencies with Kconfig
4c76d60 unicore32-softmmu.mak: express dependencies with Kconfig
8b1a2a0 sparc64-softmmu.mak: express dependencies with Kconfig
f793fdb sparc-softmmu.mak: express dependencies with Kconfig
7818fa3 sh4-softmmu.mak: express dependencies with Kconfig
3c21174 s390x: express dependencies with Kconfig
5fec60a or1k-softmmu.mak: express dependencies with Kconfig
8935c96 nios2-softmmu.mak: express dependencies with Kconfig
1d6c5fc moxie-softmmu.mak: express dependencies with Kconfig
11526a8 microblaze-softmmu.mak: express dependencies with Kconfig
6df43a7 m68k-softmmu.mak: express dependencies with Kconfig
cd79031 lm32-softmmu.mak: express dependencies with Kconfig
590c6d7 hppa-softmmu.mak: express dependencies with Kconfig
36cbe45 cris-softmmu.mak: express dependencies with Kconfig
c0cd646 alpha-softmmu.mak: express dependencies with Kconfig
6e35550 ppc: Express dependencies of the embedded machines with kconfig
ae2bd5b ppc: Express dependencies of the Sam460EX machines with kconfig
60bb2e0 ppc: Express dependencies of the Mac machines with kconfig
cf8ea0c ppc: Express dependencies of the 'prep' and '40p' machines with kconfig
93a603f ppc64: Express dependencies of 'pseries' and 'powernv' machines with 
kconfig
2822ebf i386-softmmu.mak: remove all CONFIG_* except boards definitions
db3747c ipmi: express dependencies with kconfig
ca1cfdc sd: express dependencies with kconfig
82ee5e5 ssi: express dependencies with kconfig
0d5d1a4 isa: express SuperIO dependencies with Kconfig
544527c tpm: express dependencies with Kconfig
cb5c04b virtio: express virtio dependencies with Kconfig
e4395d9 vfio: express vfio dependencies with Kconfig
7fabf6c hyperv: express dependencies with kconfig
43c36b4 display: express dependencies with kconfig
c5adaaa ptimer: express dependencies with Kconfig
140aadc i2c: express dependencies with Kconfig
192e864 i386: express dependencies with Kconfig
85489ef isa: express dependencies with kconfig
99b3ea3 scsi: express dependencies with Kconfig
b0e9cf2 block: fix recursion in hw/block/dataplane
c68b073 build: convert usb.mak to Kconfig
8b145f0 build: convert sound.mak to Kconfig
1b95de0 build: convert pci.mak to Kconfig
4af86cc hw/pci/Makefile.objs: make pcie configurable
2e3edb8 ide: express dependencies with Kconfig
f7bef1a kconfig: introduce CONFIG_TEST_DEVICES
07a8e88 minikconfig: implement allnoconfig and defconfig modes
fb806e7 build: switch to Kconfig
a95f7d7 kconfig: introduce kconfig files
1a214f8 hw/display: make edid configurable
5a8f973 minikconfig: add semantic analysis
b5c153b minikconfig: add AST
bff5450 minikconfig: add parser skeleton

=== OUTPUT BEGIN ===
1/51 Checking commit bff54501a325 (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

WARNING: line over 80 characters
#260: FILE: scripts/minikconf.py:220:
+                           'Expected identifier starting with "CONFIG_"', 
TOK_NONE)

WARNING: line over 80 characters
#359: FILE: scripts/minikconf.py:319:
+            raise KconfigParserError(self, 'expected "source", "config", 
identifier, '

WARNING: line over 80 characters
#385: FILE: scripts/minikconf.py:345:
+            raise KconfigParserError(self, 'expected "source", "config" or 
identifier')

ERROR: line over 90 characters
#410: FILE: scripts/minikconf.py:370:
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + 
length] == '|':

WARNING: line over 80 characters
#465: FILE: scripts/minikconf.py:425:
+            while self.src[self.cursor].isalnum() or self.src[self.cursor] == 
'_':

total: 1 errors, 5 warnings, 441 lines checked

Patch 1/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/51 Checking commit b5c153b336bc (minikconfig: add AST)
WARNING: line over 80 characters
#90: FILE: scripts/minikconf.py:90:
+                return "config %s default %s if %s" % (self.dest, value, 
self.cond)

total: 0 errors, 1 warnings, 177 lines checked

Patch 2/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/51 Checking commit 5a8f973a474b (minikconfig: add semantic analysis)
ERROR: line over 90 characters
#113: FILE: scripts/minikconf.py:106:
+                raise KconfigParserError('contradiction between clauses when 
setting %s' % self)

WARNING: line over 80 characters
#216: FILE: scripts/minikconf.py:218:
+            debug_print(i, "->", [str(x) for x in 
self.referenced_vars[i].outgoing])

total: 1 errors, 1 warnings, 235 lines checked

Patch 3/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/51 Checking commit 1a214f85cdc5 (hw/display: make edid configurable)
5/51 Checking commit a95f7d77eaa6 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

WARNING: line over 80 characters
#1754: FILE: scripts/minikconf.py:653:
+        print ("%s: at least one argument is required" % argv[0], 
file=sys.stderr)

total: 0 errors, 2 warnings, 1354 lines checked

Patch 5/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/51 Checking commit fb806e7b4c22 (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#505: 
deleted file mode 100644

total: 0 errors, 1 warnings, 346 lines checked

Patch 6/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/51 Checking commit 07a8e8887f8f (minikconfig: implement allnoconfig and 
defconfig modes)
8/51 Checking commit f7bef1a4465c (kconfig: introduce CONFIG_TEST_DEVICES)
9/51 Checking commit 2e3edb87047c (ide: express dependencies with Kconfig)
10/51 Checking commit 4af86cca3ac9 (hw/pci/Makefile.objs: make pcie 
configurable)
11/51 Checking commit 1b95de09b99d (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#146: 
deleted file mode 100644

total: 0 errors, 1 warnings, 490 lines checked

Patch 11/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/51 Checking commit 8b145f086b06 (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
deleted file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

Patch 12/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/51 Checking commit c68b0736c930 (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#159: 
deleted file mode 100644

total: 0 errors, 1 warnings, 165 lines checked

Patch 13/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/51 Checking commit b0e9cf200479 (block: fix recursion in hw/block/dataplane)
15/51 Checking commit 99b3ea362b48 (scsi: express dependencies with Kconfig)
16/51 Checking commit 85489ef70ed6 (isa: express dependencies with kconfig)
17/51 Checking commit 192e864c272e (i386: express dependencies with Kconfig)
18/51 Checking commit 140aadc9a3b0 (i2c: express dependencies with Kconfig)
19/51 Checking commit c5adaaac9bf3 (ptimer: express dependencies with Kconfig)
20/51 Checking commit 43c36b4f580c (display: express dependencies with kconfig)
21/51 Checking commit 7fabf6c407db (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
deleted file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Patch 21/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/51 Checking commit e4395d9fa320 (vfio: express vfio dependencies with 
Kconfig)
23/51 Checking commit cb5c04b9b9a6 (virtio: express virtio dependencies with 
Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
deleted file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 23/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/51 Checking commit 544527ca12b3 (tpm: express dependencies with Kconfig)
25/51 Checking commit 0d5d1a45050c (isa: express SuperIO dependencies with 
Kconfig)
26/51 Checking commit 82ee5e5ac54f (ssi: express dependencies with kconfig)
27/51 Checking commit ca1cfdc1c94d (sd: express dependencies with kconfig)
28/51 Checking commit db3747cb76b5 (ipmi: express dependencies with kconfig)
29/51 Checking commit 2822ebf95eae (i386-softmmu.mak: remove all CONFIG_* 
except boards definitions)
30/51 Checking commit 93a603ffb1f9 (ppc64: Express dependencies of 'pseries' 
and 'powernv' machines with kconfig)
31/51 Checking commit cf8ea0c0e8bb (ppc: Express dependencies of the 'prep' and 
'40p' machines with kconfig)
32/51 Checking commit 60bb2e0d9b9d (ppc: Express dependencies of the Mac 
machines with kconfig)
33/51 Checking commit ae2bd5b51dc8 (ppc: Express dependencies of the Sam460EX 
machines with kconfig)
34/51 Checking commit 6e35550c423c (ppc: Express dependencies of the embedded 
machines with kconfig)
35/51 Checking commit c0cd646ca528 (alpha-softmmu.mak: express dependencies 
with Kconfig)
36/51 Checking commit 36cbe4512aa8 (cris-softmmu.mak: express dependencies with 
Kconfig)
37/51 Checking commit 590c6d7ee0a4 (hppa-softmmu.mak: express dependencies with 
Kconfig)
38/51 Checking commit cd790311a0a8 (lm32-softmmu.mak: express dependencies with 
Kconfig)
39/51 Checking commit 6df43a796440 (m68k-softmmu.mak: express dependencies with 
Kconfig)
40/51 Checking commit 11526a8d824c (microblaze-softmmu.mak: express 
dependencies with Kconfig)
41/51 Checking commit 1d6c5fce702d (moxie-softmmu.mak: express dependencies 
with Kconfig)
42/51 Checking commit 8935c96d830f (nios2-softmmu.mak: express dependencies 
with Kconfig)
43/51 Checking commit 5fec60ab4271 (or1k-softmmu.mak: express dependencies with 
Kconfig)
44/51 Checking commit 3c211749036b (s390x: express dependencies with Kconfig)
45/51 Checking commit 7818fa31aef9 (sh4-softmmu.mak: express dependencies with 
Kconfig)
46/51 Checking commit f793fdb00094 (sparc-softmmu.mak: express dependencies 
with Kconfig)
47/51 Checking commit 8b1a2a062a57 (sparc64-softmmu.mak: express dependencies 
with Kconfig)
48/51 Checking commit 4c76d60e7289 (unicore32-softmmu.mak: express dependencies 
with Kconfig)
49/51 Checking commit cc20b7d742e3 (xtensa-softmmu.mak: express dependencies 
with Kconfig)
50/51 Checking commit a680cbcdd4e2 (.travis.yml: test that no-default-device 
builds do not regress)
51/51 Checking commit 93b682d47aba (FIXME vhost: add more stubs)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden