[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 07/13] vhost-user: split vhost_user_read()
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v3 07/13] vhost-user: split vhost_user_read() |
Date: |
Fri, 8 Feb 2019 12:23:51 +0100 |
Split vhost_user_read(), so only header can be read with
vhost_user_read_header().
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
---
hw/virtio/vhost-user.c | 27 +++++++++++++++++++--------
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index b2e1175c1e..0acf56fe96 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -210,7 +210,7 @@ static bool ioeventfd_enabled(void)
return !kvm_enabled() || kvm_eventfds_enabled();
}
-static int vhost_user_read(struct vhost_dev *dev, VhostUserMsg *msg)
+static int vhost_user_read_header(struct vhost_dev *dev, VhostUserMsg *msg)
{
struct vhost_user *u = dev->opaque;
CharBackend *chr = u->user->chr;
@@ -221,7 +221,7 @@ static int vhost_user_read(struct vhost_dev *dev,
VhostUserMsg *msg)
if (r != size) {
error_report("Failed to read msg header. Read %d instead of %d."
" Original request %d.", r, size, msg->hdr.request);
- goto fail;
+ return -1;
}
/* validate received flags */
@@ -229,7 +229,21 @@ static int vhost_user_read(struct vhost_dev *dev,
VhostUserMsg *msg)
error_report("Failed to read msg header."
" Flags 0x%x instead of 0x%x.", msg->hdr.flags,
VHOST_USER_REPLY_MASK | VHOST_USER_VERSION);
- goto fail;
+ return -1;
+ }
+
+ return 0;
+}
+
+static int vhost_user_read(struct vhost_dev *dev, VhostUserMsg *msg)
+{
+ struct vhost_user *u = dev->opaque;
+ CharBackend *chr = u->user->chr;
+ uint8_t *p = (uint8_t *) msg;
+ int r, size;
+
+ if (vhost_user_read_header(dev, msg) < 0) {
+ return -1;
}
/* validate message size is sane */
@@ -237,7 +251,7 @@ static int vhost_user_read(struct vhost_dev *dev,
VhostUserMsg *msg)
error_report("Failed to read msg header."
" Size %d exceeds the maximum %zu.", msg->hdr.size,
VHOST_USER_PAYLOAD_SIZE);
- goto fail;
+ return -1;
}
if (msg->hdr.size) {
@@ -247,14 +261,11 @@ static int vhost_user_read(struct vhost_dev *dev,
VhostUserMsg *msg)
if (r != size) {
error_report("Failed to read msg payload."
" Read %d instead of %d.", r, msg->hdr.size);
- goto fail;
+ return -1;
}
}
return 0;
-
-fail:
- return -1;
}
static int process_message_reply(struct vhost_dev *dev,
--
2.20.1.519.g8feddda32c
- [Qemu-devel] [PATCH v3 00/13] vhost-user-backend & vhost-user-input, Marc-André Lureau, 2019/02/08
- [Qemu-devel] [PATCH v3 01/13] libvhost-user: fix clang enum-conversion warning, Marc-André Lureau, 2019/02/08
- [Qemu-devel] [PATCH v3 02/13] vhost-user: define conventions for vhost-user backends, Marc-André Lureau, 2019/02/08
- [Qemu-devel] [PATCH v3 04/13] libvhost-user: exit by default on VHOST_USER_NONE, Marc-André Lureau, 2019/02/08
- [Qemu-devel] [PATCH v3 03/13] vhost-user: simplify vhost_user_init/vhost_user_cleanup, Marc-André Lureau, 2019/02/08
- [Qemu-devel] [PATCH v3 05/13] vhost-user: wrap some read/write with retry handling, Marc-André Lureau, 2019/02/08
- [Qemu-devel] [PATCH v3 07/13] vhost-user: split vhost_user_read(),
Marc-André Lureau <=
- [Qemu-devel] [PATCH v3 06/13] Add vhost-user-backend, Marc-André Lureau, 2019/02/08
- [Qemu-devel] [PATCH v3 08/13] vhost-user: add vhost_user_input_get_config(), Marc-André Lureau, 2019/02/08
- [Qemu-devel] [PATCH v3 09/13] libvhost-user-glib: export vug_source_new(), Marc-André Lureau, 2019/02/08
- [Qemu-devel] [PATCH v3 10/13] libvhost-user: add vu_queue_unpop(), Marc-André Lureau, 2019/02/08
- [Qemu-devel] [PATCH v3 11/13] Add vhost-user-input-pci, Marc-André Lureau, 2019/02/08