[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver |
Date: |
Fri, 8 Feb 2019 13:48:44 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 06.12.2018 um 22:50 hat Paolo Bonzini geschrieben:
> gtester is deprecated by upstream glib (see for example the announcement
> at https://blog.gtk.org/2018/07/11/news-from-glib-2-58/) and it does
> not support tests that call g_test_skip in some glib stable releases.
>
> glib suggests instead using Automake's TAP support, which gtest itself
> supports since version 2.38 (QEMU's minimum requirement is 2.40).
> We do not support Automake, but we can use Automake's code to beautify
> the TAP output. I chose to use the Perl copy rather than the shell/awk
> one, with some changes so that it can accept TAP through stdin, in order
> to reuse Perl's TAP parsing package. This also avoids duplicating the
> parser between tap-driver.pl and tap-merge.pl.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
I just wanted to work on a unit test and found that a simple 'make
check-tests/test-bdrv-drain' (which used to build and run the test with
a single command) doesn't work any more.
git bisect points to this commit.
Kevin
- Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver,
Kevin Wolf <=