[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order

From: Richard Henderson
Subject: Re: [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be
Date: Mon, 11 Feb 2019 08:11:00 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/31/19 5:40 PM, Catherine Ho wrote:
> The lo,hi order is different from the comments. And in commit
> 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128"), it changes
> the original code logic. So just restore the old code logic before this 
> commit:
> do_paired_cmpxchg64_be():
>     cmpv = int128_make128(env->exclusive_high, env->exclusive_val);
>     newv = int128_make128(new_hi, new_lo);
> Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128")
> Signed-off-by: Catherine Ho <address@hidden>
> ---

Reviewed-by: Richard Henderson <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]