[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] mips_fulong2e: Add on-board graphics chip
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] mips_fulong2e: Add on-board graphics chip |
Date: |
Tue, 12 Feb 2019 00:54:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/11/19 5:01 AM, BALATON Zoltan wrote:
> Add (partial) emulation of the on-board GPU of the machine. This
> allows the PMON2000 firmware to run and should also work with Linux
> console but probably not with X yet.
>
> Signed-off-by: BALATON Zoltan <address@hidden>
> ---
> Depends on hw/display: Add basic ATI VGA emulation
>
> hw/mips/mips_fulong2e.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index eec6fd02c8..68bd030fc1 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -287,6 +287,7 @@ static void mips_fulong2e_init(MachineState *machine)
> I2CBus *smbus;
> MIPSCPU *cpu;
> CPUMIPSState *env;
> + DeviceState *dev;
>
> /* init CPUs */
> cpu = MIPS_CPU(cpu_create(machine->cpu_type));
> @@ -347,6 +348,11 @@ static void mips_fulong2e_init(MachineState *machine)
> vt82c686b_southbridge_init(pci_bus, FULONG2E_VIA_SLOT, env->irq[5],
> &smbus, &isa_bus);
>
> + /* GPU */
> + dev = DEVICE(pci_create(pci_bus, -1, "ati-vga"));
You missed in your cover:
Based-on: address@hidden
Else testing we get:
qemu-system-mips64el: Unknown device 'ati-vga' for bus 'PCI'
Aborted (core dumped)
> + qdev_prop_set_uint16(dev, "device_id", 0x5159);
> + qdev_init_nofail(dev);
> +
> /* Populate SPD eeprom data */
> spd_data = spd_data_generate(DDR, ram_size, &err);
> if (err) {
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>