Re: [Qemu-devel] [PATCH 22/25] hw/arm: Express dependencies of nrf51 Kconfig

[Thomas Huth]

On 2019-02-11 18:37, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
> 
> On 2/9/19 7:39 AM, Thomas Huth wrote:
>> Add Kconfig dependencies for the NRF51 / microbit machine.
>>
>> Signed-off-by: Thomas Huth <address@hidden>
>> ---
>>  hw/arm/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
>> index c4b3cd2..aad2dd3 100644
>> --- a/hw/arm/Kconfig
>> +++ b/hw/arm/Kconfig
>> @@ -379,6 +379,8 @@ config FSL_IMX6UL
>>  
>>  config NRF51_SOC
>>      bool
>> +    select I2C
>> +    select ARM_V7M
> 
> Don't we need a microbit config too?

As long as we do not have another board that uses the NRF51-SoC, it does
not matter that much ... but yes, it's likely cleaner to have a proper
switch for the machine right from the start. I'll fix it in v2 ...

 Thomas