[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 01/15] s390x/tcg: Fix TEST DATA CLASS instruc

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 01/15] s390x/tcg: Fix TEST DATA CLASS instructions
Date: Wed, 13 Feb 2019 11:17:03 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 2/13/19 6:33 AM, David Hildenbrand wrote:
> Let's detect normal and denormal ("subnormal") numbers reliably. Also
> test for quiet NaN's. As only one class is possible, test common cases
> first.
> While at it, use a better check to test for the mask bits in the data
> class mask. The data class mask has 12 bits, whereby bit 0 is the
> leftmost bit and bit 11 the rightmost bit. In the PoP an easy to read
> table with the numbers is provided for the VECTOR FP TEST DATA CLASS
> IMMEDIATE instruction, the table for TEST DATA CLASS is more confusing
> as it is based on 64 bit values.
> Factor the checks out into separate functions, as they will also be
> needed for floating point vector instructions. We can use a makro to
> generate the functions.
> Signed-off-by: David Hildenbrand <address@hidden>
> ---

Reviewed-by: Richard Henderson <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]