[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 08/18] qapi: New module target.json
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v4 08/18] qapi: New module target.json |
Date: |
Thu, 14 Feb 2019 12:07:10 +0100 |
Hi
On Thu, Feb 14, 2019 at 10:50 AM Markus Armbruster <address@hidden> wrote:
>
> We can't add appropriate target-specific conditionals to misc.json,
> because that would make all of misc.json unusable in
> target-independent code. To keep misc.json target-independent, we
> need to split off target-dependent target.json.
>
> This commit doesn't actually split off anything, it merely creates the
> empty module. The next few patches will move stuff from misc.json
> there.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> Makefile.objs | 3 +--
> qapi/Makefile.objs | 28 +++++++++++++++++-----------
> qapi/qapi-schema.json | 1 +
> qapi/target.json | 13 +++++++++++++
> 4 files changed, 32 insertions(+), 13 deletions(-)
> create mode 100644 qapi/target.json
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 4a266357a2..95150d7173 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -79,8 +79,7 @@ common-obj-$(CONFIG_FDT) += device_tree.o
> ######################################################################
> # qapi
>
> -common-obj-y += qapi/qapi-commands.o
> -common-obj-y += $(QAPI_MODULES:%=qapi/qapi-commands-%.o)
> +common-obj-y += $(QAPI_COMMON_MODULES:%=qapi/qapi-commands-%.o)
> common-obj-y += qmp.o hmp.o
> endif
>
> diff --git a/qapi/Makefile.objs b/qapi/Makefile.objs
> index da0000cbae..654321de94 100644
> --- a/qapi/Makefile.objs
> +++ b/qapi/Makefile.objs
> @@ -5,21 +5,27 @@ util-obj-y += opts-visitor.o qapi-clone-visitor.o
> util-obj-y += qmp-event.o
> util-obj-y += qapi-util.o
>
> -QAPI_MODULES = block-core block char common crypto introspect job migration
> -QAPI_MODULES += misc net rdma rocker run-state sockets tpm trace transaction
> -QAPI_MODULES += ui
> +QAPI_COMMON_MODULES = block-core block char common crypto introspect
> +QAPI_COMMON_MODULES += job migration misc net rdma rocker run-state
> +QAPI_COMMON_MODULES += sockets tpm trace transaction ui
> +QAPI_TARGET_MODULES = target
> +QAPI_MODULES = $(QAPI_COMMON_MODULES) $(QAPI_TARGET_MODULES)
>
> util-obj-y += qapi-builtin-types.o
> -util-obj-y += qapi-types.o
> -util-obj-y += $(QAPI_MODULES:%=qapi-types-%.o)
> +util-obj-y += $(QAPI_COMMON_MODULES:%=qapi-types-%.o)
> util-obj-y += qapi-builtin-visit.o
> -util-obj-y += qapi-visit.o
> -util-obj-y += $(QAPI_MODULES:%=qapi-visit-%.o)
> +util-obj-y += $(QAPI_COMMON_MODULES:%=qapi-visit-%.o)
> util-obj-y += qapi-emit-events.o
> -util-obj-y += qapi-events.o
> -util-obj-y += $(QAPI_MODULES:%=qapi-events-%.o)
> +util-obj-y += $(QAPI_COMMON_MODULES:%=qapi-events-%.o)
>
> -common-obj-y += qapi-commands.o
> -common-obj-y += $(QAPI_MODULES:%=qapi-commands-%.o)
> +common-obj-y += $(QAPI_COMMON_MODULES:%=qapi-commands-%.o)
>
> +obj-y += $(QAPI_TARGET_MODULES:%=qapi-types-%.o)
> +obj-y += qapi-types.o
> +obj-y += $(QAPI_TARGET_MODULES:%=qapi-visit-%.o)
> +obj-y += qapi-visit.o
> +obj-y += $(QAPI_TARGET_MODULES:%=qapi-events-%.o)
> +obj-y += qapi-events.o
> +obj-y += $(QAPI_TARGET_MODULES:%=qapi-commands-%.o)
> +obj-y += qapi-commands.o
> obj-y += qapi-introspect.o
> diff --git a/qapi/qapi-schema.json b/qapi/qapi-schema.json
> index 1845aa78ff..db61bfd688 100644
> --- a/qapi/qapi-schema.json
> +++ b/qapi/qapi-schema.json
> @@ -97,3 +97,4 @@
> { 'include': 'trace.json' }
> { 'include': 'introspect.json' }
> { 'include': 'misc.json' }
> +{ 'include': 'target.json' }
> diff --git a/qapi/target.json b/qapi/target.json
> new file mode 100644
> index 0000000000..8054926293
> --- /dev/null
> +++ b/qapi/target.json
> @@ -0,0 +1,13 @@
> +# -*- Mode: Python -*-
> +#
> +
> +##
> +# = Target-specific commands & events
> +##
> +
> +##
> +# @TARGET-TEMPORARY-DUMMY:
> +# Will go away in the next commit. Needed in this one because empty
> +# modules don't generate anything, defeating this commit's purpose.
> +##
> +{ 'event': 'TARGET-TEMPORARY-DUMMY' }
> --
> 2.17.2
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH v4 00/18] qapi: add #if pre-processor conditions to generated code (part 3), Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 11/18] target.json: add a note about query-cpu* not being s390x-specific, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 18/18] qapi: move RTC_CHANGE to the target schema, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 02/18] qapi: Fix up documentation for recent commit a95291007b2, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 16/18] Revert "qapi-events: add 'if' condition to implicit event enum", Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 04/18] qapi: Prepare for system modules other than 'builtin', Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 08/18] qapi: New module target.json, Markus Armbruster, 2019/02/14
- Re: [Qemu-devel] [PATCH v4 08/18] qapi: New module target.json,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v4 05/18] qapi: Generate QAPIEvent stuff into separate files, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 15/18] qapi: remove qmp_unregister_command(), Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 13/18] qapi: make query-cpu-model-expansion depend on s390 or x86, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 06/18] build-sys: move qmp-introspect per target, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 07/18] build: Deal with all of QAPI's .o in qapi/Makefile.objs, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 01/18] qapi: Belatedly document modular code generation, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 09/18] qapi: make rtc-reset-reinjection and SEV depend on TARGET_I386, Markus Armbruster, 2019/02/14
- [Qemu-devel] [PATCH v4 12/18] qapi: make query-gic-capabilities depend on TARGET_ARM, Markus Armbruster, 2019/02/14