[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] scsi-cd: Fix crash after remote cdrom detached

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] scsi-cd: Fix crash after remote cdrom detached
Date: Thu, 14 Feb 2019 19:07:46 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 14/02/19 13:27, Xiang Zheng wrote:
> There is a small window between the twice blk_is_available in
> scsi_disk_emulate_command which would cause crash due to the later
> assertion if the remote cdrom is detached in this window.
> So this patch replaces assertions with return to avoid qemu crash.
> Signed-off-by: Xiang Zheng <address@hidden>
> ---
> The qemu error log shows:
> qemu-system-aarch64: /home/qemu/hw/scsi/scsi-disk.c:1896: 
> scsi_disk_emulate_command: Assertion `blk_is_available(s->qdev.conf.blk)' 
> failed.
> 2019-02-15 04:35:18.592: shutting down, reason=crashed

Is this with virtio-scsi-dataplane?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]