[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-next 3/6] blkdebug: Add @iotype error option

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH for-next 3/6] blkdebug: Add @iotype error option
Date: Fri, 15 Feb 2019 17:59:56 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0

On 14.02.19 03:35, Eric Blake wrote:
> On 12/3/18 11:52 AM, Max Reitz wrote:
>> This new error option allows users of blkdebug to inject errors only on
>> certain kinds of I/O operations.  Users usually want to make a very
>> specific operation fail, not just any; but right now they simply hope
>> that the event that triggers the error injection is followed up with
>> that very operation.  That may not be true, however, because the block
>> layer is changing (including blkdebug, which may increase the number of
>> types of I/O operations on which to inject errors).
>> The new option's default has been chosen to keep backwards
>> compatibility.
>> Note that similar to the internal representation, we could choose to
>> expose this option as a list of I/O types.  But there is no practical
>> use for this, because as described above, users usually know exactly
>> which kind of operation they want to make fail, so there is no need to
>> specify multiple I/O types at once.  In addition, exposing this option
>> as a list would require non-trivial changes to qemu_opts_absorb_qdict().
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> If you want @iotype be a list, I have patches.
> Might be interesting to see, whether or not we take them.

Here you go:


>> ---
>>  qapi/block-core.json | 26 +++++++++++++++++++++++
>>  block/blkdebug.c     | 50 ++++++++++++++++++++++++++++++++++++--------
>>  2 files changed, 67 insertions(+), 9 deletions(-)
> Reviewed-by: Eric Blake <address@hidden>

Once more, thanks!


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]