[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/12] block: Don't poll in bdrv_set_aio_context

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 08/12] block: Don't poll in bdrv_set_aio_context()
Date: Mon, 18 Feb 2019 14:52:07 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0

On 2/18/19 10:18 AM, Kevin Wolf wrote:
> The explicit aio_poll() call in bdrv_set_aio_context() was added in
> commit c2b6428d388 as a workaround for bdrv_drain() failing to achieve
> to actually quiesce everything (specifically the NBD client code to
> switch AioContext).
> Now that the NBD client has been fixed to complete this operation during
> bdrv_drain(), we don't need the workaround any more.
> It was wrong anyway: aio_poll() must always be run in the home thread of
> the AioContext.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]