[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] audio: don't use alsa by default
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH] audio: don't use alsa by default |
Date: |
Tue, 19 Feb 2019 11:15:05 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Feb 19, 2019 at 11:15:10AM +0100, Gerd Hoffmann wrote:
> In case no sound hardware is present the driver initializes
> successfully and throws errors later on, i.e. effectively the
> automatic probing doesn't work. So the driver should not be
> used by default (until that is fixed). Drop the can_be_default
> flag.
>
> Explicitly picking the alsa driver (using QEMU_AUDIO_DRV=alsa
> environment variable) will continue to work.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1816052
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> audio/alsaaudio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
> index 635be73bf4..1cc570e30b 100644
> --- a/audio/alsaaudio.c
> +++ b/audio/alsaaudio.c
> @@ -1218,7 +1218,6 @@ static struct audio_driver alsa_audio_driver = {
> .init = alsa_audio_init,
> .fini = alsa_audio_fini,
> .pcm_ops = &alsa_pcm_ops,
> - .can_be_default = 1,
> .max_voices_out = INT_MAX,
> .max_voices_in = INT_MAX,
> .voice_size_out = sizeof (ALSAVoiceOut),
This fixes the problem with alsa, but then we get exactly the same
problem with sdl audio iniitalizing but then not working.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|