Re: [Qemu-devel] [PATCH v2 2/9] tests/tcg: target/mips: Correct path to headers in some test source files

[Max Filippov]

On Tue, Feb 19, 2019 at 10:20 AM Aleksandar Markovic
<address@hidden> wrote:
> From: Aleksandar Markovic <address@hidden>
>
> Correct path to headers in tests/tcg/mips/user/ase/msa/bit-counting/*
> source files.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> Reviewed-by: Aleksandar Rikalo <address@hidden>
> ---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_b.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_d.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_h.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_w.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_b.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_d.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_h.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_w.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_b.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_d.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_h.c | 6 +++---
>  tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_w.c | 6 +++---
>  12 files changed, 36 insertions(+), 36 deletions(-)
>
> diff --git a/tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_b.c 
> b/tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_b.c
> index eb46290..d629431 100644
> --- a/tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_b.c
> +++ b/tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_b.c
> @@ -22,9 +22,9 @@
>  #include <sys/time.h>
>  #include <stdint.h>
>
> -#include "../../../include/wrappers_msa.h"
> -#include "../../../include/test_inputs.h"
> -#include "../../../include/test_utils.h"
> +#include "../../../../include/wrappers_msa.h"
> +#include "../../../../include/test_inputs.h"
> +#include "../../../../include/test_utils.h"

Wouldn't it be better to have path to include directory
somewhere in the CPPFLAGS, outside the test source code?

-- 
Thanks.
-- Max