[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 03/10] virtio-blk: add "discard" and "write-zeroe
From: |
Stefano Garzarella |
Subject: |
[Qemu-devel] [PATCH v6 03/10] virtio-blk: add "discard" and "write-zeroes" properties |
Date: |
Thu, 21 Feb 2019 11:33:07 +0100 |
In order to avoid migration issues, we enable DISCARD and
WRITE_ZEROES features only for machine type >= 4.0
As discussed with Michael S. Tsirkin and Stefan Hajnoczi on the
list [1], DISCARD operation should not have security implications
(eg. page cache attacks), so we can enable it by default.
[1] https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00504.html
Suggested-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Stefano Garzarella <address@hidden>
---
hw/block/virtio-blk.c | 4 ++++
hw/core/machine.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 7813237756..f7cd322811 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -1027,6 +1027,10 @@ static Property virtio_blk_properties[] = {
DEFINE_PROP_UINT16("queue-size", VirtIOBlock, conf.queue_size, 128),
DEFINE_PROP_LINK("iothread", VirtIOBlock, conf.iothread, TYPE_IOTHREAD,
IOThread *),
+ DEFINE_PROP_BIT64("discard", VirtIOBlock, host_features,
+ VIRTIO_BLK_F_DISCARD, true),
+ DEFINE_PROP_BIT64("write-zeroes", VirtIOBlock, host_features,
+ VIRTIO_BLK_F_WRITE_ZEROES, true),
DEFINE_PROP_END_OF_LIST(),
};
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 077fbd182a..766ca5899d 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -33,6 +33,8 @@ GlobalProperty hw_compat_3_1[] = {
{ "usb-kbd", "serial", "42" },
{ "usb-mouse", "serial", "42" },
{ "usb-kbd", "serial", "42" },
+ { "virtio-blk-device", "discard", "false" },
+ { "virtio-blk-device", "write-zeroes", "false" },
};
const size_t hw_compat_3_1_len = G_N_ELEMENTS(hw_compat_3_1);
--
2.20.1
- [Qemu-devel] [PATCH v6 00/10] virtio-blk: add DISCARD and WRITE_ZEROES features, Stefano Garzarella, 2019/02/21
- [Qemu-devel] [PATCH v6 02/10] virtio-blk: add host_features field in VirtIOBlock, Stefano Garzarella, 2019/02/21
- [Qemu-devel] [PATCH v6 01/10] virtio-blk: add acct_failed param to virtio_blk_handle_rw_error(), Stefano Garzarella, 2019/02/21
- [Qemu-devel] [PATCH v6 03/10] virtio-blk: add "discard" and "write-zeroes" properties,
Stefano Garzarella <=
- [Qemu-devel] [PATCH v6 04/10] virtio-net: make VirtIOFeature usable for other virtio devices, Stefano Garzarella, 2019/02/21
- [Qemu-devel] [PATCH v6 07/10] tests/virtio-blk: change assert on data_size in virtio_blk_request(), Stefano Garzarella, 2019/02/21
- [Qemu-devel] [PATCH v6 06/10] virtio-blk: add DISCARD and WRITE_ZEROES features, Stefano Garzarella, 2019/02/21
- [Qemu-devel] [PATCH v6 08/10] tests/virtio-blk: add virtio_blk_fix_dwz_hdr() function, Stefano Garzarella, 2019/02/21
- [Qemu-devel] [PATCH v6 05/10] virtio-blk: set config size depending on the features enabled, Stefano Garzarella, 2019/02/21
- [Qemu-devel] [PATCH v6 09/10] tests/virtio-blk: add test for WRITE_ZEROES command, Stefano Garzarella, 2019/02/21
- [Qemu-devel] [PATCH v6 10/10] tests/virtio-blk: add test for DISCARD command, Stefano Garzarella, 2019/02/21
- Re: [Qemu-devel] [PATCH v6 00/10] virtio-blk: add DISCARD and WRITE_ZEROES features, Stefan Hajnoczi, 2019/02/22