[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/8] hw/misc: mips_itu: Fix 32/64 bit issue in a line
From: |
Aleksandar Markovic |
Subject: |
[Qemu-devel] [PULL 1/8] hw/misc: mips_itu: Fix 32/64 bit issue in a line involving shift operator |
Date: |
Thu, 21 Feb 2019 13:45:53 +0100 |
From: Aleksandar Markovic <address@hidden>
Fix 32/64 bit issue in a line involving shift operator. "1 << ..."
calculation of size is done as a 32-bit signed integer which may
then be unintentionally sign-extended into the 64-bit result. The
problem was discovered by Coverity (CID 1398648). Using "1ULL"
instead of "1" on the LHS of the shift fixes this problem.
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/misc/mips_itu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/mips_itu.c b/hw/misc/mips_itu.c
index 1257d8f..3afdbe6 100644
--- a/hw/misc/mips_itu.c
+++ b/hw/misc/mips_itu.c
@@ -94,7 +94,7 @@ void itc_reconfigure(MIPSITUState *tag)
if (tag->saar_present) {
address = ((*(uint64_t *) tag->saar) & 0xFFFFFFFFE000ULL) << 4;
- size = 1 << ((*(uint64_t *) tag->saar >> 1) & 0x1f);
+ size = 1ULL << ((*(uint64_t *) tag->saar >> 1) & 0x1f);
is_enabled = *(uint64_t *) tag->saar & 1;
}
--
2.7.4
- [Qemu-devel] [PULL 0/8] MIPS queue for February 21st, 2019, Aleksandar Markovic, 2019/02/21
- [Qemu-devel] [PULL 4/8] tests/tcg: target/mips: Add wrappers for MSA integer compare instructions, Aleksandar Markovic, 2019/02/21
- [Qemu-devel] [PULL 1/8] hw/misc: mips_itu: Fix 32/64 bit issue in a line involving shift operator,
Aleksandar Markovic <=
- [Qemu-devel] [PULL 2/8] tests/tcg: target/mips: Correct path to headers in some test source files, Aleksandar Markovic, 2019/02/21
- [Qemu-devel] [PULL 3/8] tests/tcg: target/mips: Change directory name 'bit-counting' to 'bit-count', Aleksandar Markovic, 2019/02/21
- [Qemu-devel] [PULL 5/8] target/mips: implement QMP query-cpu-definitions command, Aleksandar Markovic, 2019/02/21
- [Qemu-devel] [PULL 6/8] hw/pci-host/bonito.c: Add PCI mem region mapped at the correct address, Aleksandar Markovic, 2019/02/21
- [Qemu-devel] [PULL 7/8] target/mips: fulong2e: Fix bios flash size, Aleksandar Markovic, 2019/02/21
- [Qemu-devel] [PULL 8/8] target/mips: fulong2e: Dynamically generate SPD EEPROM data, Aleksandar Markovic, 2019/02/21
- Re: [Qemu-devel] [PULL 0/8] MIPS queue for February 21st, 2019, Peter Maydell, 2019/02/21