[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/hppa/dino: mask out lower 2 bits of PCI c
|
From: |
Sven Schnelle |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/hppa/dino: mask out lower 2 bits of PCI config addr |
|
Date: |
Thu, 21 Feb 2019 15:22:46 +0100 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hi Richard,
On Wed, Feb 20, 2019 at 10:57:50AM -0800, Richard Henderson wrote:
> Can you re-test with the following?
>
> If the stores are all aligned, then the reads to not need to re-align.
> Also, partial writes to the config register don't make much sense.
> Over in hw/pci/pci_host.c, we check addr == 0 && len == 4, which is a
> very old fashioned way to do the .valid thing.
With your proposed change it works as well - should i send a v2 or will you
take care of updating the patch?
Thanks
Sven