[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/51] build: switch to Kconfig
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/51] build: switch to Kconfig |
Date: |
Thu, 21 Feb 2019 18:59:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 21/02/19 16:44, Stefano Garzarella wrote:
>> +
> Hi Paolo,
> I'm playing with Kconfig but with a simple configuration
> (./configure --target-list=x86_64-softmmu --disable-docs) the build fails:
> /usr/bin/ld: ../hw/xen/xen-legacy-backend.o: in function
> `xen_be_register_common':
> /home/stefano/repos/qemu-kconfig/hw/xen/xen-legacy-backend.c:757: undefined
> reference to `xen_9pfs_ops'
> collect2: error: ld returned 1 exit status
>
> Analyzing the Makefile.objs files maybe we should pass the CONFIG_VIRTFS from
> config-host.mak down to Kconfig.
> I tried this simple patch and it seems to fix the issue:
>
> diff --git a/Makefile b/Makefile
> index df0732a050..bad583b01c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -336,6 +336,7 @@ MINIKCONF_ARGS = \
> CONFIG_XEN=$(CONFIG_XEN) \
> CONFIG_OPENGL=$(CONFIG_OPENGL) \
> CONFIG_VHOST_USER=$(CONFIG_VHOST_USER) \
> + CONFIG_VIRTFS=$(CONFIG_VIRTFS) \
> CONFIG_LINUX=$(CONFIG_LINUX)
>
> I'm not sure if we need to add "config VIRTFS" entry in the
> Kconfig.host, because it is already defined in hw/9pfs/Kconfig.
Yes, we should remove it from hw/9pfs/Kconfig too. I had made this
exact change today in my branch. :)
Thanks!
Paolo
- [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 12/51] build: convert sound.mak to Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 09/51] ide: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 04/51] hw/display: make edid configurable, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 10/51] hw/pci/Makefile.objs: make pcie configurable, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 08/51] kconfig: introduce CONFIG_TEST_DEVICES, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 07/51] minikconfig: implement allnoconfig and defconfig modes, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 06/51] build: switch to Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 14/51] block: fix recursion in hw/block/dataplane, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 02/51] minikconfig: add AST, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 15/51] scsi: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 13/51] build: convert usb.mak to Kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 16/51] isa: express dependencies with kconfig, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 01/51] minikconfig: add parser skeleton, Paolo Bonzini, 2019/02/07
- [Qemu-devel] [PATCH 17/51] i386: express dependencies with Kconfig, Paolo Bonzini, 2019/02/07