[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/8] multifd: Change default packet size
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/8] multifd: Change default packet size |
Date: |
Thu, 21 Feb 2019 18:40:30 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
* Juan Quintela (address@hidden) wrote:
> We moved from 64KB to 512KB, as it makes less locking contention
> without any downside in testing.
>
> Signed-off-by: Juan Quintela <address@hidden>
That arbitrary number seems better than the previous arbitrary number,
so:
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/ram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 75a8fc21f8..d57db00ce4 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -521,7 +521,7 @@ exit:
> #define MULTIFD_FLAG_SYNC (1 << 0)
>
> /* This value needs to be a multiple of qemu_target_page_size() */
> -#define MULTIFD_PACKET_SIZE (64 * 1024)
> +#define MULTIFD_PACKET_SIZE (512 * 1024)
>
> typedef struct {
> uint32_t magic;
> --
> 2.20.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH v2 3/8] multifd: Create new next_packet_size field, (continued)
- [Qemu-devel] [PATCH v2 2/8] multifd: Rename "size" member to pages_alloc, Juan Quintela, 2019/02/20
- [Qemu-devel] [PATCH v2 4/8] multifd: Drop x-multifd-page-count parameter, Juan Quintela, 2019/02/20
- [Qemu-devel] [PATCH v2 8/8] tests: Add migration multifd test, Juan Quintela, 2019/02/20
- [Qemu-devel] [PATCH v2 5/8] multifd: Be flexible about packet size, Juan Quintela, 2019/02/20
- [Qemu-devel] [PATCH v2 7/8] multifd: Drop x-, Juan Quintela, 2019/02/20
- [Qemu-devel] [PATCH v2 6/8] multifd: Change default packet size, Juan Quintela, 2019/02/20
- Re: [Qemu-devel] [PATCH v2 6/8] multifd: Change default packet size,
Dr. David Alan Gilbert <=