[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] iothread: create gcontext unconditionally
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] iothread: create gcontext unconditionally |
Date: |
Fri, 22 Feb 2019 17:45:20 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Feb 22, 2019 at 10:28:57AM +0100, Paolo Bonzini wrote:
> On 22/02/19 04:14, Peter Xu wrote:
> > And if this patchset can survive... how about running gcontext
> > directly in iothread_run()? I believe there could be a bit more
> > things to clean but I'll see.
>
> Do you mean instead of aio_poll?
Yes.
> The problem is that GMainContext is
> quite a bit slower than aio_poll.
That's really what I wanted to know; so it's about performance.
We should mention it somewhere in iothread_run. I can do that after I
know how this series will go.
>
> Frediano and I tried to bring some of the optimizations of aio_poll to
> GMainContext
> (https://github.com/GNOME/glib/commit/e91c11841808ccca408da96136f433a82b2e2145),
> but they broke webkit. :(
What a pity!
--
Peter Xu