[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/10] block/dirty-bitmap: change semantics o
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 04/10] block/dirty-bitmap: change semantics of enabled predicate |
|
Date: |
Sat, 23 Feb 2019 15:14:39 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/22/19 6:06 PM, John Snow wrote:
> Currently, the enabled predicate means something like:
> "the QAPI status of the bitmap is ACTIVE."
> After this patch, it should mean exclusively:
> "This bitmap is recording guest writes, and is allowed to do so."
>
> In many places, this is how this predicate was already used.
> Internal usages of the bitmap QPI can call user_locked to find out if
> the bitmap is in use by an operation.
>
> To accommodate this, modify the create_successor routine to now
> explicitly disable the parent bitmap at creation time.
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field, John Snow, 2019/02/22
- [Qemu-devel] [PATCH v3 02/10] block/dirty-bitmaps: rename frozen predicate helper, John Snow, 2019/02/22
- [Qemu-devel] [PATCH v3 01/10] block/dirty-bitmap: add recording and busy properties, John Snow, 2019/02/22
- [Qemu-devel] [PATCH v3 04/10] block/dirty-bitmap: change semantics of enabled predicate, John Snow, 2019/02/22
- [Qemu-devel] [PATCH v3 09/10] blockdev: remove unused paio parameter documentation, John Snow, 2019/02/22
- [Qemu-devel] [PATCH v3 06/10] block/dirty-bitmap: explicitly lock bitmaps with successors, John Snow, 2019/02/22
- [Qemu-devel] [PATCH v3 05/10] nbd: change error checking order for bitmaps, John Snow, 2019/02/22
- [Qemu-devel] [PATCH v3 10/10] iotests: add busy/recording bit test to 124, John Snow, 2019/02/22