[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] iotests: handle TypeError for Python3 in tes

From: Andrey Shinkevich
Subject: Re: [Qemu-devel] [PATCH v2] iotests: handle TypeError for Python3 in test 242
Date: Mon, 25 Feb 2019 08:51:40 +0000

On 22/02/2019 17:53, Eric Blake wrote:
> On 2/22/19 5:26 AM, Andrey Shinkevich wrote:
>> The data type for bytes in Python3 differs from the one in Python2.
>> Those cases should be managed separately.
>> v1:
>> In the first version, the TypeError in Python3 was handled as the
>> exception.
>> Discussed in the e-mail thread with the Message ID:
>> <address@hidden>
> This paragraph belongs...
>> Signed-off-by: Andrey Shinkevich <address@hidden>
>> Reported-by: Kevin Wolf <address@hidden>
>> ---
> ...here, after the --- marker. It is useful to reviewers, but does not
> need to land in the long-term git history (a year from now, we won't
> care if it was v2 or v10 that landed, nor how it changed from the
> versions that didn't land).  I can clean it up on staging.
> Reviewed-by: Eric Blake <address@hidden>
> Will stage through my NBD tree.

Yes, please, Eric. Actually, I had missed to put that paragraph bellow
the dashes while composing it as a cover letter. That was my fault.
Acknowledged with thanks. I will take your comment into account for

With the best regards,
Andrey Shinkevich

reply via email to

[Prev in Thread] Current Thread [Next in Thread]