[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Maintainers, please git-am -m
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] Maintainers, please git-am -m |
Date: |
Mon, 25 Feb 2019 10:13:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/8/19 1:30 AM, Markus Armbruster wrote:
> Short story: please add
>
> [am]
> messageid = true
>
> to your .gitconfig.
>
> Long story. git-am can add a Message-id: tag. Looks like this:
>
>
> Signed-off-by: Thomas Huth <address@hidden>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
> Acked-by: Alex Bennée <address@hidden>
> ---> Message-id: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
>
> The Message-id identifies the patch e-mail. It makes finding the review
> thread easier and more reliable. It's also a valid key on Patchew[*].
I find the tag valuable enough in later git searches that I don't mind
feeding my own patches back through the mailing list to add it (patchew
helps with that, of course). But for it to become mandatory, we'd need
to enhance scripts/checkpatch.pl to enforce it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] Maintainers, please git-am -m, Markus Armbruster, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m, Thomas Huth, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m, Cornelia Huck, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m, Philippe Mathieu-Daudé, 2019/02/08
- Re: [Qemu-devel] Maintainers, please git-am -m,
Eric Blake <=