[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] target/mips: Add emulation of MMI instructi
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] target/mips: Add emulation of MMI instruction PCPYH |
|
Date: |
Mon, 25 Feb 2019 14:16:31 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/25/19 8:10 AM, Mateja Marjanovic wrote:
> + tcg_gen_andi_i64(t0, cpu_gpr[rt], mask);
tcg_gen_ext16u_i64.
> + tcg_gen_movi_i64(t1, 0);
> + tcg_gen_or_i64(t1, t0, t1);
> + tcg_gen_shli_i64(t0, t0, 16);
> + tcg_gen_or_i64(t1, t0, t1);
> + tcg_gen_shli_i64(t0, t0, 16);
> + tcg_gen_or_i64(t1, t0, t1);
> + tcg_gen_shli_i64(t0, t0, 16);
> + tcg_gen_or_i64(t1, t0, t1);
Much better as
tcg_gen_deposit(t0, t0, t0, 16, 48);
tcg_gen_deposit(t1, t0, t0, 32, 32);
r~