[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 00/18] ARM virt: Initial RAM expansion and PCDIMM
[Qemu-devel] [PATCH v8 00/18] ARM virt: Initial RAM expansion and PCDIMM/NVDIMM support
Tue, 26 Feb 2019 14:49:56 +0100
This series aims to bump the 255GB RAM limit in machvirt and to
support device memory in general, and especially PCDIMM/NVDIMM.
In machvirt versions < 4.0, the initial RAM starts at 1GB and can
grow up to 255GB. From 256GB onwards we find IO regions such as the
additional GICv3 RDIST region, high PCIe ECAM region and high PCIe
MMIO region. The address map was 1TB large. This corresponded to
the max IPA capacity KVM was able to manage.
Since 4.20, the host kernel is able to support a larger and dynamic
IPA range. So the guest physical address can go beyond the 1TB. The
max GPA size depends on the host kernel configuration and physical CPUs.
In this series we use this feature and allow the RAM to grow without
any other limit than the one put by the host kernel.
The RAM still starts at 1GB. First comes the initial ram (-m) of size
ram_size and then comes the device memory (,maxmem) of size
maxram_size - ram_size. The device memory is potentially hotpluggable
depending on the instantiated memory objects.
IO regions previously located between 256GB and 1TB are moved after
the RAM. Their offset is dynamically computed, depends on ram_size
and maxram_size. Size alignment is enforced.
In case maxmem value is inferior to 255GB, the legacy memory map
still is used. The change of memory map becomes effective from 4.0
As we keep the initial RAM at 1GB base address, we do not need to do
invasive changes in the EDK2 FW. It seems nobody is eager to do
that job at the moment.
Device memory being put just after the initial RAM, it is possible
to get access to this feature while keeping a 1TB address map.
This series reuses/rebases patches initially submitted by Shameer
in  and Kwangwoo in  for the PC-DIMM and NV-DIMM parts.
Functionally, the series is split into 3 parts:
1) bump of the initial RAM limit [1 - 10] and change in
the memory map
2) Support of PC-DIMM [11 - 13]
3) Support of NV-DIMM [14 - 18]
1) can be upstreamed before 2 and 2 can be upstreamed before 3.
Work is ongoing to transform the whole memory as device memory.
However this move is not trivial and to me, is independent on
the improvements brought by this series:
- if we were to use DIMM for initial RAM, those DIMMs would use
use slots. Although they would not be part of the ones provided
using the ",slots" options, they are ACPI limited resources.
- DT and ACPI description needs to be reworked
- NUMA integration needs special care
- a special device memory object may be required to avoid consuming
slots and easing the FW description.
So I preferred to separate the concerns. This new implementation
based on device memory could be candidate for another virt
DIMM hotplug in not supported in the series.
 [RFC v2 0/6] hw/arm: Add support for non-contiguous iova regions
 [RFC PATCH 0/3] add nvdimm support on AArch64 virt platform
This series can be found at:
v7 -> v8:
- addressed Igor's comments
- remove no_extended_memmap knob
- moved acpi_nvdimm_state into MachineState
- separate "hw/arm/virt: Check the VCPU PA range in TCG mode" patch
v6 -> v7:
- Addressed Peter and Igor comments (exceptions sent my email)
- Fixed TCG case. Now device memory works also for TCG and vcpu
pamax is checked
- See individual logs for more details
v5 -> v6:
- mingw compilation issue fix
- kvm_arm_get_max_vm_phys_shift always returns the number of supported
- new patch "hw/arm/virt: Rename highmem IO regions" that eases the review
of "hw/arm/virt: Split the memory map description"
- "hw/arm/virt: Move memory map initialization into machvirt_init"
squashed into the previous patch
- change alignment of IO regions beyond the RAM so that it matches their
v4 -> v5:
- change in the memory map
- see individual logs
v3 -> v4:
- rebase on David's "pc-dimm: next bunch of cleanups" and
"pc-dimm: pre_plug "slot" and "addr" assignment"
- kvm-type option not used anymore. We directly use
maxram_size and ram_size machine fields to compute the
MAX IPA range. Migration is naturally handled as CLI
option are kept between source and destination. This was
suggested by David.
- device_memory_start and device_memory_size not stored
anymore in vms->bootinfo
- I did not take into account 2 Igor's comments: the one
related to the refactoring of arm_load_dtb and the one
related to the generation of the dtb after system_reset
which would contain nodes of hotplugged devices (we do
not support hotplug at this stage)
- check the end-user does not attempt to hotplug a device
- addition of "vl: Set machine ram_size, maxram_size and
v2 -> v3:
- fix pc_q35 and pc_piix compilation error
- kwangwoo's email being not valid anymore, remove his address
v1 -> v2:
- kvm_get_max_vm_phys_shift moved in arch specific file
- addition of NVDIMM part
- single series
- rebase on David's refactoring
- was "[RFC 0/6] KVM/ARM: Dynamic and larger GPA size"
- was "[RFC 0/5] ARM virt: Support PC-DIMM at 2TB"
Eric Auger (13):
hw/arm/virt: Rename highmem IO regions
hw/arm/virt: Split the memory map description
hw/boards: Add a MachineState parameter to kvm_type callback
kvm: add kvm_arm_get_max_vm_ipa_size
vl: Set machine ram_size, maxram_size and ram_slots earlier
hw/arm/virt: Dynamic memory map depending on RAM requirements
hw/arm/virt: Implement kvm_type function for 4.0 machine
hw/arm/virt: Check the VCPU PA range in TCG mode
hw/arm/virt: Bump the 255GB initial RAM limit
hw/arm/virt: Add memory hotplug framework
machine: Move acpi_nvdimm_state into struct MachineState
hw/arm/boot: Expose the pmem nodes in the DT
hw/arm/virt: Allow nvdimm instantiation
Kwangwoo Lee (2):
nvdimm: Use configurable ACPI IO base and size
hw/arm/virt: Add nvdimm hot-plug infrastructure
Shameer Kolothum (3):
hw/arm/boot: introduce fdt_add_memory_node helper
hw/arm/boot: Expose the PC-DIMM nodes in the DT
hw/arm/virt-acpi-build: Add PC-DIMM in SRAT
accel/kvm/kvm-all.c | 2 +-
default-configs/arm-softmmu.mak | 4 +
hw/acpi/nvdimm.c | 30 +++-
hw/arm/boot.c | 136 ++++++++++++---
hw/arm/virt-acpi-build.c | 25 ++-
hw/arm/virt.c | 285 +++++++++++++++++++++++++++-----
hw/core/machine.c | 57 +++++++
hw/i386/acpi-build.c | 12 +-
hw/i386/acpi-build.h | 3 +
hw/i386/pc.c | 56 +------
hw/i386/pc_piix.c | 6 +-
hw/i386/pc_q35.c | 6 +-
hw/ppc/mac_newworld.c | 3 +-
hw/ppc/mac_oldworld.c | 2 +-
hw/ppc/spapr.c | 2 +-
include/hw/arm/virt.h | 19 ++-
include/hw/boards.h | 7 +-
include/hw/i386/pc.h | 4 -
include/hw/mem/nvdimm.h | 3 +
include/hw/mem/pc-dimm.h | 1 -
target/arm/kvm.c | 10 ++
target/arm/kvm_arm.h | 13 ++
vl.c | 6 +-
23 files changed, 540 insertions(+), 152 deletions(-)
- [Qemu-devel] [PATCH v8 00/18] ARM virt: Initial RAM expansion and PCDIMM/NVDIMM support,
Eric Auger <=
- [Qemu-devel] [PATCH v8 01/18] hw/arm/boot: introduce fdt_add_memory_node helper, Eric Auger, 2019/02/26
- [Qemu-devel] [PATCH v8 02/18] hw/arm/virt: Rename highmem IO regions, Eric Auger, 2019/02/26
- [Qemu-devel] [PATCH v8 03/18] hw/arm/virt: Split the memory map description, Eric Auger, 2019/02/26
- [Qemu-devel] [PATCH v8 05/18] kvm: add kvm_arm_get_max_vm_ipa_size, Eric Auger, 2019/02/26
- [Qemu-devel] [PATCH v8 04/18] hw/boards: Add a MachineState parameter to kvm_type callback, Eric Auger, 2019/02/26
- [Qemu-devel] [PATCH v8 06/18] vl: Set machine ram_size, maxram_size and ram_slots earlier, Eric Auger, 2019/02/26
- [Qemu-devel] [PATCH v8 08/18] hw/arm/virt: Implement kvm_type function for 4.0 machine, Eric Auger, 2019/02/26
- [Qemu-devel] [PATCH v8 07/18] hw/arm/virt: Dynamic memory map depending on RAM requirements, Eric Auger, 2019/02/26
- [Qemu-devel] [PATCH v8 09/18] hw/arm/virt: Check the VCPU PA range in TCG mode, Eric Auger, 2019/02/26