[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] bswap: Fix accessors syntax in comment
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] bswap: Fix accessors syntax in comment |
Date: |
Tue, 26 Feb 2019 19:36:13 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 2/26/19 3:21 PM, Greg Kurz wrote:
> All accessors that have an endian infix DO have an underscore between
> {size} and {endian}.
>
> Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/qemu/bswap.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
> index a684c1a7a298..5a70f78c0ba4 100644
> --- a/include/qemu/bswap.h
> +++ b/include/qemu/bswap.h
> @@ -255,9 +255,9 @@ typedef union {
> /*
> * the generic syntax is:
> *
> - * load: ld{type}{sign}{size}{endian}_p(ptr)
> + * load: ld{type}{sign}{size}_{endian}_p(ptr)
> *
> - * store: st{type}{size}{endian}_p(ptr, val)
> + * store: st{type}{size}_{endian}_p(ptr, val)
> *
> * Note there are small differences with the softmmu access API!
> *
> @@ -293,10 +293,10 @@ typedef union {
> *
> * For cases where the size to be used is not fixed at compile time,
> * there are
> - * stn{endian}_p(ptr, sz, val)
> + * stn_{endian}_p(ptr, sz, val)
> * which stores @val to @ptr as an @endian-order number @sz bytes in size
> * and
> - * ldn{endian}_p(ptr, sz)
> + * ldn_{endian}_p(ptr, sz)
> * which loads @sz bytes from @ptr as an unsigned @endian-order number
> * and returns it in a uint64_t.
> */
>
>