[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v3 0/8] migration: Mark multifd not experimental

From: Juan Quintela
Subject: [Qemu-devel] [PATCH v3 0/8] migration: Mark multifd not experimental
Date: Wed, 27 Feb 2019 12:08:04 +0100

- answer all comments from Dave
- updates to latest upstream.

- Measure packet size in bytes/not pages
- Change the defalut value from 64KB to 512KB
- rename used field to pages_used
- rename size field to pages_alloc
- Create nnext_packet_size field
  Will be used on compression series later.
- Be flexible about what packet sizes we allow.

Please review,

In v1:

- Change page_count default to 128.

  16 was really small, and it makes much less contention on mutexes to
  just have bigger packets.

- Drop multifd-page_count parameter

  This parameter was useful for testing, but in all my testing 128 is
  good enough, no need to have an extra knob.  Libvirt don't want to
  expose this parameter because it is difficult to explain.

- Drop experimental "x-" from multifd

  Code is stable, nothing big is happening here.

- Multifd test

  And a test for multifd, this test has already been on other patch
  series.  But now it uses the names without "-x".

Please review.

Juan Quintela (8):
  multifd: Only send pages when packet are not empty
  multifd: Rename "size" member to pages_alloc
  multifd: Create new next_packet_size field
  multifd: Drop x-multifd-page-count parameter
  multifd: Be flexible about packet size
  multifd: Change default packet size
  multifd: Drop x-
  tests: Add migration multifd test

 hmp.c                  | 17 +++------
 migration/migration.c  | 56 +++++++-----------------------
 migration/migration.h  |  1 -
 migration/ram.c        | 79 ++++++++++++++++++++++++++++++------------
 migration/trace-events |  4 +--
 qapi/migration.json    | 45 +++++++++---------------
 tests/migration-test.c | 48 +++++++++++++++++++++++++
 7 files changed, 142 insertions(+), 108 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]