[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] hw/block: better reporting on pflash backing
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v4] hw/block: better reporting on pflash backing file mismatch |
Date: |
Wed, 27 Feb 2019 09:59:38 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v4] hw/block: better reporting on pflash backing
file mismatch
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d617d4d4eb hw/block: better reporting on pflash backing file mismatch
=== OUTPUT BEGIN ===
ERROR: "(foo*)" should be "(foo *)"
#70: FILE: hw/block/pflash_cfi01.c:769:
+ memset((uint8_t*)pfl->storage + backing_len, 0xff, pad_bytes);
WARNING: line over 80 characters
#82: FILE: hw/block/pflash_cfi01.c:781:
+ warn_report("device needs %" PRIu64 " bytes, rest ignored",
total_len);
total: 1 errors, 1 warnings, 58 lines checked
Commit d617d4d4eb13 (hw/block: better reporting on pflash backing file
mismatch) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden