Re: [Qemu-devel] [PATCH v3] trivial fix of malloc to g_new in thunk

[Philippe Mathieu-Daudé]

On 2/28/19 5:46 PM, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> 
> Note that since thunking occurs throughout the lifetime of the QEMU
> instance, there is no matching 'free' to correct.
> 
> ---
>  thunk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/thunk.c b/thunk.c
> index d5d8645cd4..17f3d320bb 100644
> --- a/thunk.c
> +++ b/thunk.c
> @@ -89,7 +89,7 @@ void thunk_register_struct(int id, const char *name,
> const argtype *types)

Clearer than using a single:

       se->field_offsets = g_new(int *, nb_fields * 2);

So:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

>      for(i = 0;i < 2; i++) {

BTW we can replace here by:

       for (i = 0; i < ARRAY_SIZE(se->field_offsets); i++) {

>          offset = 0;
>          max_align = 1;
> -        se->field_offsets[i] = malloc(nb_fields * sizeof(int));
> +        se->field_offsets[i] = g_new(int, nb_fields);
>          type_ptr = se->field_types;
>          for(j = 0;j < nb_fields; j++) {
>              size = thunk_type_size(type_ptr, i);
>