Re: [Qemu-devel] [PATCH] tests/qemu-iotests/235: Allow fallback to tcg and remove it from quick group

[Vladimir Sementsov-Ogievskiy]

01.03.2019 15:20, Thomas Huth wrote:
> iotest 235 currently only works with KVM - this is bad for systems where
> it is not available, e.g. CI pipelines. The test also works when using
> "tcg" as accelerator, so we can simply add that to the list of accelerators,
> too. But still, there might be the case that someone compiled their
> QEMU with --disable-tcg and still try to run the iotests in a CI pipeline
> where KVM is not available - in that case it would be best to use the
> "qtest" accelerator for this test. However, that currently hangs and I
> did not succeed to get it working with "accel=qtest" yet.

hmm, interesting, I can reproduce it. I think we'd better fix it instead..
I'll try but not now.

Thus, as long
> as this is not fixed, it's likely better to remove this test from the
> "quick" group so that it does not fail on CI pipelines.
> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>   tests/qemu-iotests/235   | 2 +-
>   tests/qemu-iotests/group | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qemu-iotests/235 b/tests/qemu-iotests/235
> index d6edd97..90ef785 100755
> --- a/tests/qemu-iotests/235
> +++ b/tests/qemu-iotests/235
> @@ -49,7 +49,7 @@ qemu_img_create('-f', iotests.imgfmt, '-o', 
> 'preallocation=metadata', disk,
>                   str(size))
>   
>   vm = QEMUMachine(iotests.qemu_prog)
> -vm.add_args('-machine', 'accel=kvm')
> +vm.add_args('-machine', 'accel=kvm:tcg')

I tested now with accel=tcg, and it doesn't reproduce original bug.. On, the 
other hand,
if kvm is not available anyway, why not run test for tcg, may be it'll find 
some other bug.

>   if iotests.qemu_default_machine == 's390-ccw-virtio':
>           vm.add_args('-no-shutdown')
>   vm.add_args('-drive', 'id=src,file=' + disk)
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index b5ca63c..12ebeba 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -234,7 +234,7 @@
>   232 auto quick
>   233 auto quick
>   234 auto quick migration
> -235 auto quick
> +235 auto
>   236 auto quick
>   237 rw auto quick
>   238 auto quick
> 


-- 
Best regards,
Vladimir