[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 05/73] cpu: move run_on_cpu to cpus-common
From: |
Emilio G. Cota |
Subject: |
[Qemu-devel] [PATCH v7 05/73] cpu: move run_on_cpu to cpus-common |
Date: |
Mon, 4 Mar 2019 13:17:05 -0500 |
We don't pass a pointer to qemu_global_mutex anymore.
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
---
include/qom/cpu.h | 10 ----------
cpus-common.c | 2 +-
cpus.c | 5 -----
3 files changed, 1 insertion(+), 16 deletions(-)
diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 62f4dc9025..eab86205c1 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -781,16 +781,6 @@ void qemu_cpu_kick(CPUState *cpu);
*/
bool cpu_is_stopped(CPUState *cpu);
-/**
- * do_run_on_cpu:
- * @cpu: The vCPU to run on.
- * @func: The function to be executed.
- * @data: Data to pass to the function.
- *
- * Used internally in the implementation of run_on_cpu.
- */
-void do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data);
-
/**
* run_on_cpu:
* @cpu: The vCPU to run on.
diff --git a/cpus-common.c b/cpus-common.c
index daf1531868..85a61eb970 100644
--- a/cpus-common.c
+++ b/cpus-common.c
@@ -127,7 +127,7 @@ static void queue_work_on_cpu(CPUState *cpu, struct
qemu_work_item *wi)
cpu_mutex_unlock(cpu);
}
-void do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data)
+void run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data)
{
struct qemu_work_item wi;
bool has_bql = qemu_mutex_iothread_locked();
diff --git a/cpus.c b/cpus.c
index 4057c3a7e5..253c1f1a59 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1234,11 +1234,6 @@ void qemu_init_cpu_loop(void)
qemu_thread_get_self(&io_thread);
}
-void run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data)
-{
- do_run_on_cpu(cpu, func, data);
-}
-
static void qemu_kvm_destroy_vcpu(CPUState *cpu)
{
if (kvm_destroy_vcpu(cpu) < 0) {
--
2.17.1
- [Qemu-devel] [PATCH v7 00/73] per-CPU locks, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 05/73] cpu: move run_on_cpu to cpus-common,
Emilio G. Cota <=
- [Qemu-devel] [PATCH v7 01/73] cpu: convert queued work to a QSIMPLEQ, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 08/73] tcg-runtime: define helper_cpu_halted_set, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 06/73] cpu: introduce process_queued_cpu_work_locked, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 04/73] cpu: make qemu_work_cond per-cpu, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 09/73] ppc: convert to helper_cpu_halted_set, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 07/73] cpu: make per-CPU locks an alias of the BQL in TCG rr mode, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 23/73] mips: convert to cpu_halted, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 50/73] mips: convert to cpu_interrupt_request, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 03/73] cpu: introduce cpu_mutex_lock/unlock, Emilio G. Cota, 2019/03/04
- [Qemu-devel] [PATCH v7 02/73] cpu: rename cpu->work_mutex to cpu->lock, Emilio G. Cota, 2019/03/04