qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4? 0/1] update copyright notice


From: David Kiarie
Subject: Re: [Qemu-devel] [PATCH v4? 0/1] update copyright notice
Date: Tue, 5 Mar 2019 17:16:07 +0300

On Mon, Mar 4, 2019 at 11:52 PM Eric Blake <address@hidden> wrote:

> On 3/4/19 9:18 AM, David Kiarie wrote:
> > i think it is best put as i've updated.
> >
> > David Kiarie (1):
> >    update copyright notice
> >
> >   hw/i386/amd_iommu.c | 2 +-
> >   hw/i386/amd_iommu.h | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
>
> You have now posted two separate threads with identical subjects but
> with different contents. As a courtesy to your reviewers, and to help
> the maintainers know for sure which version you want incorporated, it
> would have been nicer if you had used 'git send-email -v4' for this
> series, to differentiate it from v3 (if I counted right) sent at
> https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg06457.html, as
> well as summarizing how this version differs from the previous.
>
> That said, I do not think you need to send a v5 just to fix the subject
> line in the cover letter (as the cover letter doesn't end up in git
> anyways), especially since Paolo has already said he will queue your
> patch, and I trust Paolo to get the right version included.
>

i am not okay with maintainer behaviour, this is just something personal.

i will definitely send v4 but this series will include a patch stripping
all AMD IOMMU code from for Paolo to choose what to merge.


> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]