Re: [Qemu-devel] [PULL 00/54] Kconfig conversion, excluding ARM and MIPS

[Paolo Bonzini]

On 06/03/19 12:04, Thomas Huth wrote:
> On 06/03/2019 11.57, Paolo Bonzini wrote:
>> On 05/03/19 10:32, Peter Maydell wrote:
>>> Everything fails to build with errors like
>>> make: *** No rule to make target `config-all-devices.mak', needed by
>>> `subdir-aarch64-softmmu'.  Stop.
>>>
>>> or
>>> make: *** No rule to make target
>>> `/home/pm215/qemu/default-configs/pci.mak', needed by
>>> `aarch64-softmmu/config-devices.mak'.  Stop.
>>>
>>> If there are special instructions for what to do with
>>> build trees over the transition to kconfig, the pullreq
>>> cover letter would be a good place to mention them :-)
>>
>> As others mentioned, this is the "usual" stale dependency issue
>> requiring distclean.
> 
> Can't we somehow add a dependency for the *.mak.d file so that they get
> regenerated in this case? ... I tried to hack the Makefile, but so far I
> failed...

What we should do is add dummy dependencies for the .mak files, so that
they do not trigger the error messages; this is how gcc -MD avoids the
issue for include files.

With Kconfig it should be a one-line patch, something like

    for fname in data.previously_included:
        print('%s: %s' % (argv[1], fname), file=deps)
        print('%s:' % fname, file=deps)

but it wouldn't fix this case where the stale .mak file is preexisting.

Paolo