Re: [Qemu-devel] [PULL 00/22] migration queue

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/22] migration queue

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
060f501bdc qapi/migration.json: Remove a variable that doesn't exist in example
79985c89a1 Migration/colo.c: Make COLO node running after failover
04fa41f3fe Migration/colo.c: Fix double close bug when occur COLO failover
fad6a7a2fe virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT
ea055843a6 migration/ram.c: add the free page optimization enable flag
04f12f4493 migration/ram.c: add a notifier chain for precopy
acffe8fac2 migration: API to clear bits of guest free pages from the dirty 
bitmap
28ba7920b5 migration: use bitmap_mutex in migration_bitmap_clear_dirty
50d141e21b bitmap: bitmap_count_one_with_offset
d09d8c34fe bitmap: fix bitmap_count_one
0b3f876f73 tests: Add basic migration precopy tcp test
b9b8858224 migration: Create socket-address parameter
c3e10e38d0 tests: Add migration xbzrle test
9891a178e1 migration: Add capabilities validation
a3ba078ea3 tests/migration-test: Add a test for ignore-shared capability
40a11f6d72 migration: Add an ability to ignore shared RAM blocks
b08a8bcb8f migration: Introduce ignore-shared capability
502f3e7690 exec: Change RAMBlockIterFunc definition
1419fc4f68 migration/rdma: clang compilation fix
af4a8e34f7 migration: Cleanup during exit
6078675984 migration/rdma: Fix qemu_rdma_cleanup null check
f414a0d58c migration: Fix cancel state

=== OUTPUT BEGIN ===
1/22 Checking commit f414a0d58c61 (migration: Fix cancel state)
2/22 Checking commit 60786759846a (migration/rdma: Fix qemu_rdma_cleanup null 
check)
3/22 Checking commit af4a8e34f76a (migration: Cleanup during exit)
4/22 Checking commit 1419fc4f68a6 (migration/rdma: clang compilation fix)
5/22 Checking commit 502f3e769033 (exec: Change RAMBlockIterFunc definition)
6/22 Checking commit b08a8bcb8f55 (migration: Introduce ignore-shared 
capability)
7/22 Checking commit 40a11f6d720b (migration: Add an ability to ignore shared 
RAM blocks)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#149: FILE: migration/ram.c:169:
+#define RAMBLOCK_FOREACH_NOT_IGNORED(block)            \
+    INTERNAL_RAMBLOCK_FOREACH(block)                   \
+        if (ramblock_is_ignored(block)) {} else

ERROR: trailing statements should be on next line
#151: FILE: migration/ram.c:171:
+        if (ramblock_is_ignored(block)) {} else

total: 2 errors, 0 warnings, 386 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/22 Checking commit a3ba078ea311 (tests/migration-test: Add a test for 
ignore-shared capability)
ERROR: if this code is redundant consider removing it
#235: FILE: tests/migration-test.c:829:
+#if 0

total: 1 errors, 0 warnings, 255 lines checked

Patch 8/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/22 Checking commit 9891a178e1cb (migration: Add capabilities validation)
10/22 Checking commit c3e10e38d0a5 (tests: Add migration xbzrle test)
11/22 Checking commit b9b885822408 (migration: Create socket-address parameter)
12/22 Checking commit 0b3f876f7352 (tests: Add basic migration precopy tcp test)
13/22 Checking commit d09d8c34fe5f (bitmap: fix bitmap_count_one)
14/22 Checking commit 50d141e21bda (bitmap: bitmap_count_one_with_offset)
15/22 Checking commit 28ba7920b5e4 (migration: use bitmap_mutex in 
migration_bitmap_clear_dirty)
16/22 Checking commit acffe8fac2f4 (migration: API to clear bits of guest free 
pages from the dirty bitmap)
17/22 Checking commit 04f12f44931e (migration/ram.c: add a notifier chain for 
precopy)
18/22 Checking commit ea055843a6f6 (migration/ram.c: add the free page 
optimization enable flag)
19/22 Checking commit fad6a7a2fe5e (virtio-balloon: 
VIRTIO_BALLOON_F_FREE_PAGE_HINT)
20/22 Checking commit 04fa41f3fed6 (Migration/colo.c: Fix double close bug when 
occur COLO failover)
21/22 Checking commit 79985c89a1be (Migration/colo.c: Make COLO node running 
after failover)
22/22 Checking commit 060f501bdcb2 (qapi/migration.json: Remove a variable that 
doesn't exist in example)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden