Re: [Qemu-devel] [PATCH 2/4] nvdimm: use *function* directly instead of allocating it again

[Igor Mammedov]

On Wed, 27 Feb 2019 15:50:59 +0800
Wei Yang <address@hidden> wrote:

> At the beginning or nvdimm_build_common_dsm(), variable *function* is
> already allocated for Arg2.
> 
> This patch reuse variable *function* instead of allocating it again.

Reviewed-by: Igor Mammedov <address@hidden>

> 
> Signed-off-by: Wei Yang <address@hidden>
> ---
>  hw/acpi/nvdimm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> index 39af8cdba8..e63a1ef15d 100644
> --- a/hw/acpi/nvdimm.c
> +++ b/hw/acpi/nvdimm.c
> @@ -1086,7 +1086,7 @@ static void nvdimm_build_common_dsm(Aml *dev)
>       */
>      aml_append(method, aml_store(handle, aml_name(NVDIMM_DSM_HANDLE)));
>      aml_append(method, aml_store(aml_arg(1), aml_name(NVDIMM_DSM_REVISION)));
> -    aml_append(method, aml_store(aml_arg(2), aml_name(NVDIMM_DSM_FUNCTION)));
> +    aml_append(method, aml_store(function, aml_name(NVDIMM_DSM_FUNCTION)));
>  
>      /*
>       * The fourth parameter (Arg3) of _DSM is a package which contains