Re: [Qemu-devel] [PATCH v3 01/12] docs/cpu-hotplug.rst: Fix rST markup issues

[Cleber Rosa]

On Thu, Mar 07, 2019 at 09:47:18AM +0000, Peter Maydell wrote:
> On Thu, 7 Mar 2019 at 00:04, Cleber Rosa <address@hidden> wrote:
> > But I'm assuming the extended sphinx roles/directives will be used, so
> > the only way to check against future breakage would be to build the
> > docs.
> >
> > Do we have strong position in favor or against putting that into the
> > "common" `make check` flow?
> 
> Assuming the host has sphinx-build, the docs will be built as
> part of "make", so actual errors will be caught. We should

That's even better IMO.

> add the sphinx-build flag to make warnings into errors in
> the same way we use -Werror, but I wanted to get the series
> into master first.
>

Absolutely!

Regards,
- Cleber.

> thanks
> -- PMM