[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/4] tests/bios-tables: Improve portability b
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/4] tests/bios-tables: Improve portability by searching bash in the $PATH |
Date: |
Thu, 7 Mar 2019 20:50:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 07/03/2019 15.58, Philippe Mathieu-Daudé wrote:
> Bash is not always installed as /bin/bash. In particular on OpenBSD,
> the package installs it in /usr/local/bin.
> Use the 'env' shebang to search bash in the $PATH.
>
> Reviewed-by: Kamil Rytarowski <address@hidden>
> Reviewed-by: Igor Mammedov <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/data/acpi/rebuild-expected-aml.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/data/acpi/rebuild-expected-aml.sh
> b/tests/data/acpi/rebuild-expected-aml.sh
> index bf9ba242ad..abdff70a0d 100755
> --- a/tests/data/acpi/rebuild-expected-aml.sh
> +++ b/tests/data/acpi/rebuild-expected-aml.sh
> @@ -1,4 +1,4 @@
> -#! /bin/bash
> +#!/usr/bin/env bash
>
> #
> # Rebuild expected AML files for acpi unit-test
>
In case Kevin wants to pick this up, too:
Acked-by: Thomas Huth <address@hidden>
Otherwise, I can take this one also through the qtest tree.
- [Qemu-devel] [PATCH v4 0/4] tests: Allow use of Ports bash and GNU sed extensions, Philippe Mathieu-Daudé, 2019/03/07
- [Qemu-devel] [PATCH v4 2/4] tests/bios-tables: Improve portability by searching bash in the $PATH, Philippe Mathieu-Daudé, 2019/03/07
- Re: [Qemu-devel] [PATCH v4 2/4] tests/bios-tables: Improve portability by searching bash in the $PATH,
Thomas Huth <=
- [Qemu-devel] [PATCH v4 1/4] tests/multiboot: Improve portability by searching bash in the $PATH, Philippe Mathieu-Daudé, 2019/03/07
- [Qemu-devel] [PATCH v4 4/4] qemu-iotests: Ensure GNU sed is used, Philippe Mathieu-Daudé, 2019/03/07
- [Qemu-devel] [PATCH v4 3/4] qemu-iotests: Improve portability by searching bash in the $PATH, Philippe Mathieu-Daudé, 2019/03/07
- Re: [Qemu-devel] [PATCH v4 0/4] tests: Allow use of Ports bash and GNU sed extensions, Thomas Huth, 2019/03/07
- Re: [Qemu-devel] [PATCH v4 0/4] tests: Allow use of Ports bash and GNU sed extensions, Kevin Wolf, 2019/03/07