Re: [Qemu-devel] [PATCH v7 2/2] mips_fulong2e: Add on-board graphics chip

[Philippe Mathieu-Daudé]

On 3/9/19 6:21 PM, BALATON Zoltan wrote:
> Add (partial) emulation of the on-board GPU of the machine. This
> allows the PMON2000 firmware to run and should also work with Linux
> console but probably not with X yet.
> 
> Signed-off-by: BALATON Zoltan <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>

Mojibaked again :(

I guess this is the last respin and this series will be applied,
so to the maintainer: Can you fix using:

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

Zoltan if you have to respin, please simply use:

Reviewed-by: Philippe Mathieu-Daude <address@hidden>
Tested-by: Philippe Mathieu-Daude <address@hidden>

> Reviewed-by: Aleksandar Markovic <address@hidden>
> ---
> v7:
> - set vgamem_mb explicitely to match board instead of relying on default
> 
>  hw/mips/mips_fulong2e.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index fbbc543eed..2bdb766ed1 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -287,6 +287,7 @@ static void mips_fulong2e_init(MachineState *machine)
>      I2CBus *smbus;
>      MIPSCPU *cpu;
>      CPUMIPSState *env;
> +    DeviceState *dev;
>  
>      /* init CPUs */
>      cpu = MIPS_CPU(cpu_create(machine->cpu_type));
> @@ -347,6 +348,12 @@ static void mips_fulong2e_init(MachineState *machine)
>      vt82c686b_southbridge_init(pci_bus, FULONG2E_VIA_SLOT, env->irq[5],
>                                 &smbus, &isa_bus);
>  
> +    /* GPU */
> +    dev = DEVICE(pci_create(pci_bus, -1, "ati-vga"));
> +    qdev_prop_set_uint32(dev, "vgamem_mb", 16);
> +    qdev_prop_set_uint16(dev, "x-device-id", 0x5159);
> +    qdev_init_nofail(dev);
> +
>      /* Populate SPD eeprom data */
>      spd_data = spd_data_generate(DDR, ram_size, &err);
>      if (err) {
>