Re: [Qemu-devel] [PATCH 2/8] hw/input: Add 8042 PS/2 Keyboard Controller to Kconfig

[Philippe Mathieu-Daudé]

On 3/11/19 7:47 AM, Thomas Huth wrote:
> On 11/03/2019 00.53, Philippe Mathieu-Daudé wrote:
>> The Intel 8042 chipset also includes some functions unrelated to
>> the keyboard, such the A20-Gate.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>>  hw/input/Kconfig | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/hw/input/Kconfig b/hw/input/Kconfig
>> index e2e66f0858..83e4546a28 100644
>> --- a/hw/input/Kconfig
>> +++ b/hw/input/Kconfig
>> @@ -10,6 +10,10 @@ config PCKBD
>>      default y
>>      depends on ISA_BUS
>>  
>> +config I8042
>> +    bool
>> +    select PCKBD
> 
> I fail to see why you need this config switch. There is a "select I8042"
> in a later patch, but that's it - you never use this switch to decide
> anything (like including a file in the Makefiles or toggle other
> switches), so this seems to be just a defunc switch to me. Or do I miss
> something?

The PIIX3 emulates a 8042 when the USB Legacy Support is enabled.

Oh now I see, I first understood the hw/input/pckbd.c file was
modeling the 8042 and other things, but no, it is simply it.

So please disregard this patch, I'll respin renaming PCKBD -> I8042.

Thanks!

Phil.