qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU


From: Aleksandar Markovic
Subject: Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU
Date: Mon, 11 Mar 2019 11:52:06 +0000

> From: Mateja Marjanovic <address@hidden>
> Subject: [PATCH] target/mips: Fix minor bug in FPU
>
> Wrong type of NaN was generated by maddf and msubf insturctions
> when the arguments were inf, zero, nan or zero, inf, nan
> respectively.

I did the applicable tests on both pre-NaN2008 and NaN2008 MIPS hardware,
and compared results with QEMu emulations. The underlying reason for this
patch is correct, but, as Alex also pointed out, it needs some improvements.
However, the softfreeze being so close, I am going to amend the patch while
creating the pull request. No respin needed. All in all:

Reviewed-by: Aleksandar Markovic <address@hidden>










reply via email to

[Prev in Thread] Current Thread [Next in Thread]