[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/10] qemu-binfmt-conf.sh: add --test|--dry-
From: |
Unai Martinez Corral |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/10] qemu-binfmt-conf.sh: add --test|--dry-run |
Date: |
Mon, 11 Mar 2019 14:04:57 +0100 |
2019/3/11 11:45, Laurent Vivier:
> > while true ; do
> > case "$1" in
> > + -t|--test|--dry-run)
>
> We don't need multiple parameter for the same effect. You must choose
> between --test and --dry-run.
Ok. I'll take 'test', because the short for '--dry-run' would be '-d'
and it is already used for 'debian'.
> > +if [ "x$QEMU_TEST" = "xyes" ] ; then
> > + skip(){
> > + :;}
> > + BINFMT_SET=skip
>
> Why do you need a function?
> Can't you set directly BINFMT_SET to ':'?
Indeed...
Regards,
Unai
- Re: [Qemu-devel] [PATCH v4 7/10] qemu-binfmt-conf.sh: generalize CPU to positional TARGETS, (continued)
[Qemu-devel] [PATCH v4 8/10] qemu-binfmt-conf.sh: add option --clear, Unai Martinez-Corral, 2019/03/11
[Qemu-devel] [PATCH v4 9/10] qemu-binfmt-conf.sh: update usage(), Unai Martinez-Corral, 2019/03/11
[Qemu-devel] [PATCH v4 10/10] qemu-binfmt-conf.sh: add --test|--dry-run, Unai Martinez-Corral, 2019/03/11
Re: [Qemu-devel] [PATCH v4 0/10] qemu-binfmt-conf.sh, no-reply, 2019/03/11
Re: [Qemu-devel] [PATCH v4 0/10] qemu-binfmt-conf.sh, no-reply, 2019/03/11