Re: [Qemu-devel] [PATCH v4 7/10] qemu-binfmt-conf.sh: generalize CPU to positional TARGETS

[Unai Martinez Corral]

2019/3/11 12:14, Laurent Vivier:
> On 11/03/2019 11:30, Unai Martinez-Corral wrote:

> > +        if [ "$unknown_target" = "true" ] ; then
>
>            if [ "x$cpu" != "x$target" ] ; then

My bad. I fixed it before squashing, and broke it again when doing it.

> > +-s|--systemd:                         don't write into /proc, generate 
> > file(s) for
> > +                                      systemd-binfmt.service; environment 
> > variable HOST_ARCH
>
> why HOST_ARCH appears here?

The existing comment seems to be specific to systemd:
https://github.com/qemu/qemu/blob/master/scripts/qemu-binfmt-conf.sh#L201-L204
'systemd' is the single mode in which it makes sense to generate a
bunch of configuration files for a different architecture than the
current one, isn't it?

Regards,
Unai