Re: [Qemu-devel] [PATCH 6/6] target/m68k: Reduce the scope of the 'zero' tcg_temp

[Richard Henderson]

On 3/9/19 4:34 PM, Philippe Mathieu-Daudé wrote:
>      if (left) {
> +        TCGv zero = tcg_const_i32(0);
>          tcg_gen_mov_i32(shl, shift);      /* shl = shift */
>          tcg_gen_movi_i32(shr, size + 1);
>          tcg_gen_sub_i32(shr, shr, shift); /* shr = size + 1 - shift */
>          tcg_gen_subi_i32(shx, shift, 1);  /* shx = shift - 1 */
>          /* shx = shx < 0 ? size : shx; */
> -        zero = tcg_const_i32(0);
>          tcg_gen_movcond_i32(TCG_COND_LT, shx, shx, zero, sz, shx);
> -        tcg_temp_free(zero);
> +        tcg_temp_free_i32(zero);

But you're extending its lifetime.

r~