[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/11] target/hppa: allow multiple itlbp without
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 08/11] target/hppa: allow multiple itlbp without itlba |
Date: |
Mon, 11 Mar 2019 18:22:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 3/11/19 12:15 PM, Sven Schnelle wrote:
> The ODE software calls itlbp on existing TLB entries without
> calling itlba first, so this seems to be valid.
>
> Signed-off-by: Sven Schnelle <address@hidden>
> ---
> target/hppa/mem_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c
> index 26da953185..fc1b6a4fcd 100644
> --- a/target/hppa/mem_helper.c
> +++ b/target/hppa/mem_helper.c
> @@ -277,7 +277,7 @@ void HELPER(itlbp)(CPUHPPAState *env, target_ulong addr,
> target_ureg reg)
> {
> hppa_tlb_entry *ent = hppa_find_tlb(env, addr);
>
> - if (unlikely(ent == NULL || ent->entry_valid)) {
> + if (unlikely(ent == NULL)) {
> qemu_log_mask(LOG_GUEST_ERROR, "ITLBP not following ITLBA\n");
> return;
> }
>
Hmm. Do you have a broader context for this? Like maybe the software has just
flushed the entire TLB? If the entry is valid, and we're not relaxing
permissions, then we might need to flush the softtlb page as well.
r~
- Re: [Qemu-devel] [PATCH 05/11] target/hppa: remove PSW I/R/Q bit check, (continued)
- [Qemu-devel] [PATCH 01/11] target/hppa: fix overwriting source reg in addb, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 02/11] target/hppa: fix TLB handling for page 0, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 03/11] target/hppa: report ITLB_EXCP_MISS for ITLB misses, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 04/11] target/hppa: add TLB trace events, Sven Schnelle, 2019/03/11
- [Qemu-devel] [PATCH 08/11] target/hppa: allow multiple itlbp without itlba, Sven Schnelle, 2019/03/11
- Re: [Qemu-devel] [PATCH 08/11] target/hppa: allow multiple itlbp without itlba,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH 00/11] target/hppa patches, no-reply, 2019/03/11
- Re: [Qemu-devel] [PATCH 00/11] target/hppa patches, Richard Henderson, 2019/03/12