[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/10] tests/virtio-blk-test: Disable auto-re
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/10] tests/virtio-blk-test: Disable auto-read-only |
Date: |
Mon, 11 Mar 2019 21:50:34 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/11/19 11:50 AM, Kevin Wolf wrote:
> tests/virtio-blk-test uses a temporary image file that it deletes while
> QEMU is still running, so it can't be reopened when writers are
> attached or detached. Disable auto-read-only to keep it always writable.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/virtio-blk-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks like I started reviewing v1 even though I see v2 has been posted.
R-b carries forward:
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c
> index b02be0274e..b65365934b 100644
> --- a/tests/virtio-blk-test.c
> +++ b/tests/virtio-blk-test.c
> @@ -751,7 +751,7 @@ static void *virtio_blk_test_setup(GString *cmd_line,
> void *arg)
> char *tmp_path = drive_create();
>
> g_string_append_printf(cmd_line,
> - " -drive if=none,id=drive0,file=%s,format=raw "
> + " -drive
> if=none,id=drive0,file=%s,format=raw,auto-read-only=off "
> "-drive
> if=none,id=drive1,file=null-co://,format=raw ",
> tmp_path);
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 07/10] file-posix: Store BDRVRawState.reopen_state during reopen, (continued)
- [Qemu-devel] [PATCH v2 07/10] file-posix: Store BDRVRawState.reopen_state during reopen, Kevin Wolf, 2019/03/11
- [Qemu-devel] [PATCH v2 06/10] file-posix: Factor out raw_reconfigure_getfd(), Kevin Wolf, 2019/03/11
- [Qemu-devel] [PATCH v2 05/10] file-posix: Fix bdrv_open_flags() for snapshot=on, Kevin Wolf, 2019/03/11
- [Qemu-devel] [PATCH v2 04/10] block: Make permission changes in reopen less wrong, Kevin Wolf, 2019/03/11
- [Qemu-devel] [PATCH v2 03/10] block: Avoid useless local_err, Kevin Wolf, 2019/03/11
- [Qemu-devel] [PATCH v2 02/10] qemu-iotests: commit to backing file with auto-read-only, Kevin Wolf, 2019/03/11
- [Qemu-devel] [PATCH v2 01/10] tests/virtio-blk-test: Disable auto-read-only, Kevin Wolf, 2019/03/11
- Re: [Qemu-devel] [PATCH v2 01/10] tests/virtio-blk-test: Disable auto-read-only,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 00/10] file-posix: Make auto-read-only dynamic, Peter Krempa, 2019/03/11