Re: [Qemu-devel] [PATCH v6 09/11] hw/pvrdma: Delete pvrdma_exit function

[Kamal Heib]

On 3/11/19 12:29 PM, Yuval Shaia wrote:
> This hook is not called and was implemented by mistake.
> 
> Signed-off-by: Yuval Shaia <address@hidden>
> Reviewed-by: Marcel Apfelbaum <address@hidden>
> ---
>  hw/rdma/vmw/pvrdma_main.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
> index 04845f4..a4afced 100644
> --- a/hw/rdma/vmw/pvrdma_main.c
> +++ b/hw/rdma/vmw/pvrdma_main.c
> @@ -654,11 +654,6 @@ out:
>      }
>  }
>  
> -static void pvrdma_exit(PCIDevice *pdev)
> -{
> -    pvrdma_fini(pdev);
> -}
> -
>  static void pvrdma_class_init(ObjectClass *klass, void *data)
>  {
>      DeviceClass *dc = DEVICE_CLASS(klass);
> @@ -666,7 +661,6 @@ static void pvrdma_class_init(ObjectClass *klass, void 
> *data)
>      RdmaProviderClass *ir = INTERFACE_RDMA_PROVIDER_CLASS(klass);
>  
>      k->realize = pvrdma_realize;
> -    k->exit = pvrdma_exit;
>      k->vendor_id = PCI_VENDOR_ID_VMWARE;
>      k->device_id = PCI_DEVICE_ID_VMWARE_PVRDMA;
>      k->revision = 0x00;
> 

Reviewed-by: Kamal Heib <address@hidden>