[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/13] block: Add a 'mutable_opts' field to B
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/13] block: Add a 'mutable_opts' field to BlockDriver |
Date: |
Tue, 12 Mar 2019 13:47:44 +0100 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 12.03.2019 um 13:32 hat Kevin Wolf geschrieben:
> Am 06.03.2019 um 19:11 hat Alberto Garcia geschrieben:
> > If we reopen a BlockDriverState and there is an option that is present
> > in bs->options but missing from the new set of options then we have to
> > return an error unless the driver is able to reset it to its default
> > value.
> >
> > This patch adds a new 'mutable_opts' field to BlockDriver. This is
> > a list of runtime options that can be modified during reopen. If an
> > option in this list is unspecified on reopen then it must be reset (or
> > return an error).
> >
> > Signed-off-by: Alberto Garcia <address@hidden>
> > ---
> > block/file-posix.c | 6 ++++++
> > block/qcow2.c | 25 +++++++++++++++++++++++++
> > block/raw-format.c | 3 +++
> > include/block/block_int.h | 8 ++++++++
> > 4 files changed, 42 insertions(+)
>
> Two more drivers seem to be able to change options: gluster (debug and
> logfile) and throttle (throttle-group).
Actually those aren't necessary in this patch: throttle-group isn't even
optional, so it never has to be reset; and I misread the gluster code,
it just re-adds the old values for debug and logfile and doesn't
actually accept changes.
So the patch looks fine, after all.
Kevin
- [Qemu-devel] [PATCH v2 00/13] Add a 'x-blockdev-reopen' QMP command, Alberto Garcia, 2019/03/06
- [Qemu-devel] [PATCH v2 06/13] block: Handle child references in bdrv_reopen_queue(), Alberto Garcia, 2019/03/06
- [Qemu-devel] [PATCH v2 08/13] block: Allow changing the backing file on reopen, Alberto Garcia, 2019/03/06
- [Qemu-devel] [PATCH v2 11/13] block: Remove the AioContext parameter from bdrv_reopen_multiple(), Alberto Garcia, 2019/03/06
- [Qemu-devel] [PATCH v2 05/13] block: Add 'keep_old_opts' parameter to bdrv_reopen_queue(), Alberto Garcia, 2019/03/06
- [Qemu-devel] [PATCH v2 09/13] block: Add a 'mutable_opts' field to BlockDriver, Alberto Garcia, 2019/03/06
- [Qemu-devel] [PATCH v2 04/13] block: Freeze the backing chain for the duration of the stream job, Alberto Garcia, 2019/03/06
- [Qemu-devel] [PATCH v2 10/13] block: Add bdrv_reset_options_allowed(), Alberto Garcia, 2019/03/06
- [Qemu-devel] [PATCH v2 13/13] qemu-iotests: Test the x-blockdev-reopen QMP command, Alberto Garcia, 2019/03/06
- [Qemu-devel] [PATCH v2 03/13] block: Freeze the backing chain for the duration of the mirror job, Alberto Garcia, 2019/03/06
- [Qemu-devel] [PATCH v2 01/13] block: Allow freezing BdrvChild links, Alberto Garcia, 2019/03/06